← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1572670] Re: Ovs agent should set min burst value if user don't provide it

 

Reviewed:  https://review.openstack.org/311609
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f766fc71bedc58a0cff0c6dc6e5576f0ab5e2507
Submitter: Jenkins
Branch:    master

commit f766fc71bedc58a0cff0c6dc6e5576f0ab5e2507
Author: Sławek Kapłoński <slawek@xxxxxxxxxxxx>
Date:   Sat Apr 30 00:53:22 2016 +0200

    Add setting default max_burst value if not given by user
    
    If user will not provide burst value for bandwidth limit rule there is
    need to set such value on appropriate to ensure that bandwith limit
    will work fine.
    To ensure at least proper limitation of TCP traffic we decided to set
    burst as 80% of bw_limit value.
    LinuxBridge agent already sets is like that. This patch add same
    behaviour for QoS extension driver in openvswitch L2 agent.
    
    DocImpact: Add setting default max_burst value in LB and OvS drivers
    
    Change-Id: Ib12a7cbf88cdffd10c8f6f8442582bf7377ca27d
    Closes-Bug: #1572670


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1572670

Title:
  Ovs agent should set min burst value if user don't provide it

Status in neutron:
  Fix Released

Bug description:
  If user will set QoS bw_limit rule without giving burst value (or this burst is set to 0kb) then bw limit could may not work properly with TCP
  which is the most common protocol. We should change openvswitch QoS driver to set min burst value as 80 % of configured bw_limit. 80% is value which should works fine for TCP traffic.
  Such change will make consistent behaviour between Linuxbridge agent and openvswitch agent. See on https://launchpad.net/bugs/1563720 for LB implementation details.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1572670/+subscriptions


References