← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1582589] [NEW] ComputeCapacityFilter always reject irrelevant, self-defined specs

 

Public bug reported:

Master branch 2016.5.17

When I enabe ComputeCapacityFilter:
If I define a irrelevant specs in flavor like key='x' value='y'
ComputeCapacityFilter will return flase,I can't create instances.

If I define a irrelevant specs like key='mykey:x' value='y'
ComputeCapacityFilter will return True

This means if I don't add a head string and a colon before my real key,
ComputeCapacityFilter doesn't permit me to use it.

If this kind of specs is not allowed,I believe this should be refused in
horizon or api,not in filter.

But when i read test_compute_capabilities_filters.py, I find it is
permitted,but only for ComputeCapacityFilter's specs.

code:
    def test_compute_filter_pass_extra_specs_same_as_scope(self):
        # Make sure this still works even if the key is the same as the scope
        self._do_test_compute_filter_extra_specs(
            ecaps={'capabilities': 1},
            especs={'capabilities': '1'},
            passes=True)

** Affects: nova
     Importance: Undecided
     Assignee: octopuszhang (1004988384-n)
         Status: New

** Changed in: nova
     Assignee: (unassigned) => octopuszhang (1004988384-n)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1582589

Title:
  ComputeCapacityFilter always reject irrelevant,self-defined specs

Status in OpenStack Compute (nova):
  New

Bug description:
  Master branch 2016.5.17

  When I enabe ComputeCapacityFilter:
  If I define a irrelevant specs in flavor like key='x' value='y'
  ComputeCapacityFilter will return flase,I can't create instances.

  If I define a irrelevant specs like key='mykey:x' value='y'
  ComputeCapacityFilter will return True

  This means if I don't add a head string and a colon before my real
  key, ComputeCapacityFilter doesn't permit me to use it.

  If this kind of specs is not allowed,I believe this should be refused
  in horizon or api,not in filter.

  But when i read test_compute_capabilities_filters.py, I find it is
  permitted,but only for ComputeCapacityFilter's specs.

  code:
      def test_compute_filter_pass_extra_specs_same_as_scope(self):
          # Make sure this still works even if the key is the same as the scope
          self._do_test_compute_filter_extra_specs(
              ecaps={'capabilities': 1},
              especs={'capabilities': '1'},
              passes=True)

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1582589/+subscriptions


Follow ups