← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1582605] [NEW] Instance is left in migrating state when graphics addresses check fails

 

Public bug reported:

At the beginning of live migration nova makes some checks on source and
destination hosts to make sure both are capable of hosting new instance.
One of these checks is "_check_graphics_addresses_can_live_migrate":

https://github.com/openstack/nova/blob/71e4e54f97c220b693fa3bad905079819fada65a/nova/virt/libvirt/driver.py#L5633

If this check fails, it will raise MigrationError:

https://github.com/openstack/nova/blob/71e4e54f97c220b693fa3bad905079819fada65a/nova/virt/libvirt/driver.py#L5651

Which is not handled by conductor-manager:

https://github.com/openstack/nova/blob/71e4e54f97c220b693fa3bad905079819fada65a/nova/conductor/manager.py#L312

This results in Internal Error 500 in the API and instance left in
MIGRATING state. Because these are only checks before live migration, we
shouldn't return 500 through the API and we should revert state of a VM.

** Affects: nova
     Importance: Undecided
     Assignee: Pawel Koniszewski (pawel-koniszewski)
         Status: New


** Tags: live-migration

** Changed in: nova
     Assignee: (unassigned) => Pawel Koniszewski (pawel-koniszewski)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1582605

Title:
  Instance is left in migrating state when graphics addresses check
  fails

Status in OpenStack Compute (nova):
  New

Bug description:
  At the beginning of live migration nova makes some checks on source
  and destination hosts to make sure both are capable of hosting new
  instance. One of these checks is
  "_check_graphics_addresses_can_live_migrate":

  https://github.com/openstack/nova/blob/71e4e54f97c220b693fa3bad905079819fada65a/nova/virt/libvirt/driver.py#L5633

  If this check fails, it will raise MigrationError:

  https://github.com/openstack/nova/blob/71e4e54f97c220b693fa3bad905079819fada65a/nova/virt/libvirt/driver.py#L5651

  Which is not handled by conductor-manager:

  https://github.com/openstack/nova/blob/71e4e54f97c220b693fa3bad905079819fada65a/nova/conductor/manager.py#L312

  This results in Internal Error 500 in the API and instance left in
  MIGRATING state. Because these are only checks before live migration,
  we shouldn't return 500 through the API and we should revert state of
  a VM.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1582605/+subscriptions


Follow ups