yahoo-eng-team team mailing list archive

[Zhenguo Niu <Niu.ZGlinux@xxxxxxxxx>]

Public bug reported:

In ironic driver, before really do deploy, we will first validate
whether the node is ready to deploy by calling ironic node.validate
method.

# validate we are ready to do the deploy
    validate_chk = self.ironicclient.call("node.validate", node_uuid)
    if not validate_chk.deploy or not validate_chk.power:
        # something is wrong. undo what we have done

Here, the condition validte_chk.deploy and validate_chk.power will
always be true, as they are dict like {deploy: {reason: "xxxx", result:
False}, power: {result: False}}

so we should change to check validate_chk.deploy.get('result') and
validate_chk.power.get('result').

** Affects: nova
     Importance: Undecided
     Assignee: Zhenguo Niu (niu-zglinux)
         Status: New

** Changed in: nova
     Assignee: (unassigned) => Zhenguo Niu (niu-zglinux)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1582680

Title:
  Ironic: wrong check for ready to deploy

Status in OpenStack Compute (nova):
  New

Bug description:
  In ironic driver, before really do deploy, we will first validate
  whether the node is ready to deploy by calling ironic node.validate
  method.

  # validate we are ready to do the deploy
      validate_chk = self.ironicclient.call("node.validate", node_uuid)
      if not validate_chk.deploy or not validate_chk.power:
          # something is wrong. undo what we have done

  Here, the condition validte_chk.deploy and validate_chk.power will
  always be true, as they are dict like {deploy: {reason: "xxxx",
  result: False}, power: {result: False}}

  so we should change to check validate_chk.deploy.get('result') and
  validate_chk.power.get('result').

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1582680/+subscriptions