yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #51051
[Bug 1185083] Re: VMware: Simplify logic get_network_with_the_name
This wishlist bug has been open a year without any activity. I'm going
to move it to "Opinion / Wishlist", which is an easily-obtainable queue
of older requests that have come on. This bug can be reopened (set back
to "New") if someone decides to work on this.
** Changed in: nova
Status: Confirmed => Opinion
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1185083
Title:
VMware: Simplify logic get_network_with_the_name
Status in OpenStack Compute (nova):
Opinion
Bug description:
The method get_network_with_the_name features several points of repeated code that does not need to be repeated.
* network._type is always a unique and valid argument for get_dynamic_property
* networks will usually have 0 or 1 result, more results will be due to networks sharing the same name which will make them indistinguishable (this should be considered an exceptional case)
* multiple return points should not be necessary particularly since we are working with 0 or 1 valid values.
See:
https://github.com/openstack/nova/blob/master/nova/virt/vmwareapi/network_util.py#L32
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1185083/+subscriptions