← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1581669] Re: Preview Page: Modal location is off

 

Reviewed:  https://review.openstack.org/316279
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=16895968a9be63d457de19566d5bffd20befe867
Submitter: Jenkins
Branch:    master

commit 16895968a9be63d457de19566d5bffd20befe867
Author: Diana Whitten <hurgleburgler@xxxxxxxxx>
Date:   Fri May 13 13:30:00 2016 -0700

    Preview Page: Modal location is off
    
    There is JavaScript in horizon that is forcing a hardcoded inline
    style for the top offset of the modal. This is causing shenanigans
    on the theme preview page for the lower sections.
    
    There existed a hardcoded CSS class in _debt.scss that was undoing
    this JavaScript hardcode, but neither is needed.  Bootstrap should
    work properly by itself.
    
    Closes-bug: #1581669
    
    Change-Id: I3bab355be0c53fdd3c6ba8c91846c6c54ebcee4d


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1581669

Title:
  Preview Page: Modal location is off

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Preview Page: Modal location is off

  There is JavaScript in horizon that is forcing a hardcoded top offset
  for the modal.  This is causing shenanigans on the theme preview page
  for the lower sections.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1581669/+subscriptions


References