← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1529012] Re: Miss policy checks in image panels

 

Reviewed:  https://review.openstack.org/261967
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=340e67c17acf5957890c5ae3ec5f5c7216c20587
Submitter: Jenkins
Branch:    master

commit 340e67c17acf5957890c5ae3ec5f5c7216c20587
Author: Bo Wang <bo.wang@xxxxxxxxxxxx>
Date:   Tue Apr 12 14:16:11 2016 +0800

    Add policy checks in images panels
    
    check policy of getting images in:
    project/images
    project/ngimages
    admin/images
    
    Only block listing images but not whole panel if failed on policy check.
    Create, Delete and other actions are controlled by according policys.
    give a message "Insufficient privilege level to get images." to user
    if polciy checks failed.
    
    Closes-Bug: #1529012
    Change-Id: I97ab081425dd56fa7c3208efb58ba8b041eaba24


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1529012

Title:
  Miss policy checks in image panels

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  There is no policy checking code in image panels: project/images,
  project/ngimages,  admin/images.

  As ngusers code:
  https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/identity/static/dashboard/identity/users/table/table.controller.js#L54.

  We should add policy checks of "get_images" in image panels

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1529012/+subscriptions


References