yahoo-eng-team team mailing list archive

[OpenStack Infra <1543327@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/317293
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=18b351b9c47f180118b10dcf3229e6265c811493
Submitter: Jenkins
Branch:    master

commit 18b351b9c47f180118b10dcf3229e6265c811493
Author: wangbo <wangbo_bupt@xxxxxxx>
Date:   Tue May 17 15:12:40 2016 +0800

    Angular pages will reload if collapse/expand sidebar
    
    use ng-images as example to explan the issue:
    1.enable ng-images page and go into this page.
    2.click left sidebar to collapse/expand a dashboard or panel-group
    3.the url change to "project/ngimages/#sidebar-accordion-***" which
      match the route[1]. Current page will reload even it's not change.
    
    Use "data-target" instead of "href" to fix it. ref:[2]
    
    [1]https://github.com/openstack/horizon/blob/master/
    openstack_dashboard/static/app/core/images/images.module.js#L190
    [2]https://github.com/openstack/xstatic-bootstrap-scss/blob/
    master/xstatic/pkg/bootstrap_scss/data/js/bootstrap.js#L505
    
    Change-Id: I1c84c6af49a67bf2833ad5b0103f6cbd4abd0ddb
    Closes-Bug: #1543327


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1543327

Title:
  Angular controllers (routes being evaluated) on django navbar clicks
  (hash routing)

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  While evaluating another patch, I found that if I'm on an angular page
  (ng-images) that whenever I click an accordion on the horizon navbar
  (e.g. start on Project --> Images, then click Admin) this is causing
  the current angular controller to refresh.

  
  See picture, but note that I have paused the debugger in a Keystone API hit, that you can see the requests in the terminal window, and that in the URL you can see #sidebar-accordion-admin.

  http://pasteboard.co/1pw530qO.png

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1543327/+subscriptions