yahoo-eng-team team mailing list archive

[OpenStack Infra <1582087@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/315580
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c195d1f756b502952a4751e0a760286e55c6a825
Submitter: Jenkins
Branch:    master

commit c195d1f756b502952a4751e0a760286e55c6a825
Author: ZhiQiang Fan <aji.zqfan@xxxxxxxxx>
Date:   Fri May 13 05:52:47 2016 +0800

    fix wrong default value of qos.notification_drivers
    
    It is a list option, not str type.
    
    Change-Id: I79c4c8815019e38504106398ce2d1e370364b7b7
    Closes-bug: #1582087


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1582087

Title:
  The default value of neutron.qos.notification_drivers should be a list

Status in neutron:
  Fix Released

Bug description:
  Now the default value of neutron.qos.notification_drivers is a string
  [1]. This will not have functional error because the oslo can consume
  string and turn to list. But for the sample.conf file, it will
  generate something like this:

  #
  # From neutron.qos
  #

  # Drivers list to use to send the update notification (list value)
  #notification_drivers = m,e,s,s,a,g,e,_,q,u,e,u,e

  which is not user-friendly. Change the default value to a list can eliminate this issue.
  [1] https://github.com/openstack/neutron/blob/67bb052111440120497727a9ede89643fb466077/neutron/services/qos/notification_drivers/manager.py#L21

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1582087/+subscriptions