yahoo-eng-team team mailing list archive

[OpenStack Infra <1584558@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/319720
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=208c96ab1438e643eb274aaf0c07883c556cd635
Submitter: Jenkins
Branch:    master

commit 208c96ab1438e643eb274aaf0c07883c556cd635
Author: liangjingtao <liang.jingtao@xxxxxxxxxx>
Date:   Mon May 23 11:29:41 2016 +0800

    Normalize the options use singele quotes
    
    Some config options in codes use double quotes
    but most of the options use single quotes and
    that need to be normalized
    
    DocImpact
    Closes-Bug: #1584558
    
    Change-Id: I828326d9bb22b6cb98885255ebc0dfcc1efc0497


** Changed in: glance
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1584558

Title:
  Some config options in codes use double quotes but most of the options
  use single quotes and that need to be normalized

Status in Glance:
  Fix Released

Bug description:
  description:

  most options like this use '':
  volume_manager_opts = [
      cfg.StrOpt('volume_driver',
                 default='cinder.volume.drivers.lvm.LVMISCSIDriver',
                 help='Driver to use for volume creation'),
      cfg.IntOpt('migration_create_volume_timeout_secs',
                 default=300,
                 help='Timeout for creating the volume to migrate to '
                      'when performing volume migration (seconds)'),
      cfg.BoolOpt('volume_service_inithost_offload',
                  default=False,
                  help='Offload pending volume delete during '
                       'volume service startup'),
      cfg.StrOpt('zoning_mode',
                 default='none',
                 help='FC Zoning mode configured'),
      cfg.StrOpt('extra_capabilities',
                 default='{}',
                 help='User defined capabilities, a JSON formatted string '
                      'specifying key/value pairs. The key/value pairs can '
                      'be used by the CapabilitiesFilter to select between '
                      'backends when requests specify volume types. For '
                      'example, specifying a service level or the geographical '
                      'location of a backend, then creating a volume type to '
                      'allow the user to select by these different '
                      'properties.'),
  ]

  
  but some option like this use ""
  store_type_opts = [
      cfg.ListOpt("store_type_preference",
                  default=[],
                  help=_("The store names to use to get store preference order. "
                         "The name must be registered by one of the stores "
                         "defined by the 'stores' config option. "
                         "This option will be applied when you using "
                         "'store_type' option as image location strategy "
                         "defined by the 'location_strategy' config option."))
  ]
  profiler_opts = [
      cfg.BoolOpt("enabled", default=False,
                  help=_('If False fully disable profiling feature.')),
      cfg.BoolOpt("trace_sqlalchemy", default=False,
                  help=_("If False doesn't trace SQL requests."))
  ]

  I think it's need to normalize

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1584558/+subscriptions