← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1584207] Re: Angular Edit Image buttons styled wrong

 

Reviewed:  https://review.openstack.org/319955
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=14f40d67991cc7ad4e55b71f5f9c4df18c67b201
Submitter: Jenkins
Branch:    master

commit 14f40d67991cc7ad4e55b71f5f9c4df18c67b201
Author: Matt Borland <matt.borland@xxxxxxx>
Date:   Mon May 23 08:01:40 2016 -0600

    Use 'label' rather than 'button' for buttons in Edit Image
    
    Per the bug, it seems the styling for the Edit buttons requires that the
    elements are of type 'label' and not type 'button.'  Otherwise, the buttons
    look odd, particularly if you look at them in the 'Material' theme.  This
    patch changes those buttons to labels.
    
    Change-Id: I4f329513f0ec093fae84394c3094dc526e1a9b9e
    Closes-Bug: 1584207


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1584207

Title:
  Angular Edit Image buttons styled wrong

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  If you compare the buttons in the Angular Edit Image versus the Create
  Image, you'll notice that the Edit Image buttons look odd.  This is
  because they use the wrong element for styling (button instead of
  label).  This may actually be more of a global styling problem, but
  for now we should just align the two to look nice.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1584207/+subscriptions


References