yahoo-eng-team team mailing list archive

[jingtao liang <liang.jingtao@xxxxxxxxxx>]

Public bug reported:

description:

When uploading image by the way of  "copy-from" failed because of "Remote server where the image is present is unavailable".The function return, the  process will work on and print the log like this:
"Uploaded data of image 952a0e62-500e-44fb-bbc4-f8cc17b5b6a4 from request payload successfully"
That is unreasonable.

glance/api/v1/images.py

        if copy_from:
            try:
                image_data, image_size = self._get_from_store(req.context,
                                                              copy_from,
                                                              dest=store)
            except Exception:
                upload_utils.safe_kill(req, image_meta['id'], 'queued')
                msg = (_LE("Copy from external source '%(scheme)s' failed for "
                           "image: %(image)s") %
                       {'scheme': scheme, 'image': image_meta['id']})
                LOG.exception(msg)
                return

** Affects: glance
     Importance: Undecided
     Assignee: jingtao liang (liang-jingtao)
         Status: In Progress

** Changed in: glance
     Assignee: (unassigned) => jingtao liang (liang-jingtao)

** Changed in: glance
       Status: New => In Progress

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1585122

Title:
  Uploading image failed but print successful log

Status in Glance:
  In Progress

Bug description:
  description:

  When uploading image by the way of  "copy-from" failed because of "Remote server where the image is present is unavailable".The function return, the  process will work on and print the log like this:
  "Uploaded data of image 952a0e62-500e-44fb-bbc4-f8cc17b5b6a4 from request payload successfully"
  That is unreasonable.

  glance/api/v1/images.py

          if copy_from:
              try:
                  image_data, image_size = self._get_from_store(req.context,
                                                                copy_from,
                                                                dest=store)
              except Exception:
                  upload_utils.safe_kill(req, image_meta['id'], 'queued')
                  msg = (_LE("Copy from external source '%(scheme)s' failed for "
                             "image: %(image)s") %
                         {'scheme': scheme, 'image': image_meta['id']})
                  LOG.exception(msg)
                  return

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1585122/+subscriptions