yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #51769
[Bug 1578233] Re: functional tests fail with native ovsdb_interface enabled
Reviewed: https://review.openstack.org/312697
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=bffc5f062c15757b58a597e0f1e380aa4d9166c6
Submitter: Jenkins
Branch: master
commit bffc5f062c15757b58a597e0f1e380aa4d9166c6
Author: Inessa Vasilevskaya <ivasilevskaya@xxxxxxxxxxxx>
Date: Wed May 4 17:36:47 2016 +0300
functional: fix OVSFW failure with native OVSDB api
A bunch of functional tests fail because of non implemented
x != [] operation in idlutils.condition_match() and
wrong condition passed to db_find() in OVSFW test.
This patch addresses the issue by implementing lists
comparison in native.idlutils and fixing the call to
db_find() in OVSFW test.
A functional test for OVSDB API's db_find() has been
added to ensure that querying a list column gives the same
result both with vsctl and native ovsdb_interface; unit
test for idlutils.condition_match() with corner cases has
been added as well.
Change-Id: Ia93fb925b8814210975904a453249f15f3646855
Closes-bug: #1578233
** Changed in: neutron
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1578233
Title:
functional tests fail with native ovsdb_interface enabled
Status in neutron:
Fix Released
Bug description:
When ovsdb_interface in config is set to native, a bunch of functional
tests fails because of non-implemented comparison-to-list in search
query
(https://github.com/openstack/neutron/blob/master/neutron/agent/ovsdb/native/idlutils.py#L169)
Typical output for neutron.tests.functional.agent.test_firewall tests
ft29.1: neutron.tests.functional.agent.test_firewall.FirewallTestCase.test_allowed_address_pairs(OVS Firewall Driver)_StringException: Empty attachments:
pythonlogging:''
stderr
stdout
Traceback (most recent call last):
File "neutron/tests/functional/agent/test_firewall.py", line 98, in setUp
self.assign_vlan_to_peers()
File "neutron/tests/functional/agent/test_firewall.py", line 132, in assign_vlan_to_peers
vlan = self.get_not_used_vlan()
File "neutron/tests/functional/agent/test_firewall.py", line 140, in get_not_used_vlan
used_vlan_tags = {val['tag'] for val in port_vlans}
File "neutron/tests/functional/agent/test_firewall.py", line 140, in <setcomp>
used_vlan_tags = {val['tag'] for val in port_vlans}
TypeError: unhashable type: 'list'
To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1578233/+subscriptions
References