← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1580809] Re: hz-expand-detail cannot be used outside of hz-table

 

Reviewed:  https://review.openstack.org/321089
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=fe98059ca108d80b412e73ec373904c310795b37
Submitter: Jenkins
Branch:    master

commit fe98059ca108d80b412e73ec373904c310795b37
Author: Tyr Johanson <tyr@xxxxxx>
Date:   Wed May 25 09:49:06 2016 -0600

    Relax hz-table parent requirement
    
    hz-expand-detail is a pretty handy directive to use in normal
    HTML tables. This patch changes the parent directive requirement
    to be optional.
    
    Change-Id: Ic0b0c7af6143ec1d654cb277503342693d051b50
    Closes-Bug: #1580809


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1580809

Title:
  hz-expand-detail cannot be used outside of hz-table

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  hz-expand-detail is a reasonably handy directive that allows row
  expansion. It was modified to allow a table user to detect row
  expansion. However, this modification added a require of the hz-table
  controller.

  This is not necessary, is difficult to maintain and prevents the reuse
  of this with anything other than hz-table.

  Instead, the directive should simply emit an event and any parent that
  cares can listen for it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1580809/+subscriptions


References