yahoo-eng-team team mailing list archive

[Richard Jones <r1chardj0n3s@xxxxxxxxx>]

Public bug reported:

The documentation for the selection functionality for hz-table says to
configure the checkbox as:

     <input type='checkbox' hz-select='row'
       ng-model='tCtrl.selections[row.id].checked'/>

The problem is that the row select checkbox click handler currently
performs this check (in tCtrl toggleSelect):

      if (angular.isDefined(ctrl.selections[key])) {
        ctrl.selections[key].checked = checkedState;
      } else {
        ctrl.selections[key] = { checked: checkedState, item: row };
      }

The problem is that the row will always exist in selections, so the
second branch will never fire, thus never setting the item.

This is reproducable in the /project/ngimages/ view with the batch
delete.

** Affects: horizon
     Importance: Undecided
         Status: Invalid

** Changed in: horizon
       Status: New => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1590649

Title:
  Incorrect prior state check in hz-table select box handler

Status in OpenStack Dashboard (Horizon):
  Invalid

Bug description:
  The documentation for the selection functionality for hz-table says to
  configure the checkbox as:

       <input type='checkbox' hz-select='row'
         ng-model='tCtrl.selections[row.id].checked'/>

  The problem is that the row select checkbox click handler currently
  performs this check (in tCtrl toggleSelect):

        if (angular.isDefined(ctrl.selections[key])) {
          ctrl.selections[key].checked = checkedState;
        } else {
          ctrl.selections[key] = { checked: checkedState, item: row };
        }

  The problem is that the row will always exist in selections, so the
  second branch will never fire, thus never setting the item.

  This is reproducable in the /project/ngimages/ view with the batch
  delete.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1590649/+subscriptions