yahoo-eng-team team mailing list archive

[OpenStack Infra <1585373@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/325644
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=3c27beb8c0fe9b511bae78412b0623835a81f63f
Submitter: Jenkins
Branch:    master

commit 3c27beb8c0fe9b511bae78412b0623835a81f63f
Author: Sławek Kapłoński <slawek@xxxxxxxxxxxx>
Date:   Sun Jun 5 09:49:27 2016 +0000

    Fix update of shared QoS policy
    
    When user updates QoS policy which is globaly shared, it will be still
    marked as globally shared even if this flag was not set explicitly
    in update request.
    For example, updating description of QoS policy will not change shared
    flag to default value which is "False".
    
    Co-Authored-By: Haim Daniel <hdaniel@xxxxxxxxxx>
    
    Change-Id: I2c59e71eae0bf2e73475bba321afc4aaa514b317
    Closes-Bug: #1585373


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1585373

Title:
  qos-policy update without specify --shared causing it change to
  default False

Status in neutron:
  Fix Released

Bug description:
  update policy 3k-bm-limiter as shared policy.
  update policy 3k-bm-limiter with only name field, causing default field shared=False being used.

  Here is the console log:

  nicira@newton-devstack:~$ neutron qos-policy-show 3k-bm-limiter
  +-------------+--------------------------------------------------------------+
  | Field       | Value                                                        |
  +-------------+--------------------------------------------------------------+
  | description | bw-limit 3k                                                  |
  | id          | 163c5fc1-7bf2-455b-a92c-4118fc612822                         |
  | name        | 3k-bm-limiter                                                |
  | rules       | 76344f3d-0933-4cd6-be97-918aebe4741c (type: bandwidth_limit) |
  | shared      | False                                                        |
  | tenant_id   | 1cf34eba3d3240a68966ef61567c5650                             |
  +-------------+--------------------------------------------------------------+
  nicira@newton-devstack:~$ neutron qos-policy-update --shared 3k-bm-limiter
  Updated policy: 3k-bm-limiter
  nicira@newton-devstack:~$ neutron qos-policy-show 3k-bm-limiter
  +-------------+--------------------------------------------------------------+
  | Field       | Value                                                        |
  +-------------+--------------------------------------------------------------+
  | description | bw-limit 3k                                                  |
  | id          | 163c5fc1-7bf2-455b-a92c-4118fc612822                         |
  | name        | 3k-bm-limiter                                                |
  | rules       | 76344f3d-0933-4cd6-be97-918aebe4741c (type: bandwidth_limit) |
  | shared      | True                                                         |
  | tenant_id   | 1cf34eba3d3240a68966ef61567c5650                             |
  +-------------+--------------------------------------------------------------+
  nicira@newton-devstack:~$ neutron qos-policy-update --name=bw-limiter 3k-bm-limiter           
  Updated policy: 3k-bm-limiter
  nicira@newton-devstack:~$ neutron qos-policy-show bw-limiter
  +-------------+--------------------------------------------------------------+
  | Field       | Value                                                        |
  +-------------+--------------------------------------------------------------+
  | description | bw-limit 3k                                                  |
  | id          | 163c5fc1-7bf2-455b-a92c-4118fc612822                         |
  | name        | bw-limiter                                                   |
  | rules       | 76344f3d-0933-4cd6-be97-918aebe4741c (type: bandwidth_limit) |
  | shared      | False                                                        |
  | tenant_id   | 1cf34eba3d3240a68966ef61567c5650                             |
  +-------------+--------------------------------------------------------------+
  nicira@newton-devstack:~$

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1585373/+subscriptions