← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1581159] Re: ceph testing: parsing osd crush rule dump devstack output with awk is wrong

 

Reviewed:  https://review.openstack.org/315703
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=95720664902ad247b99e8c0f1c7e97a717c2b3ef
Submitter: Jenkins
Branch:    master

commit 95720664902ad247b99e8c0f1c7e97a717c2b3ef
Author: Jon Bernard <jobernar@xxxxxxxxxx>
Date:   Thu May 12 14:09:02 2016 -0400

    live-migration ceph: fix typo in ruleset parsing
    
    The rule_id line is formatted as:
    
    "rule_id": 0,
    
    Which means the id integer is the second column of the parsed output,
    not the third.
    
    Since a third column doesn't exist, the call to cut returns nothing,
    leaving $RULE_ID invalid, which then causes the subsequent ruleset
    commands to fail.
    
    We don't see this normally because $CEPH_REPLICAS is set to 1 by
    default.
    
    Change-Id: I3255f9421119aafb7407ba7443400bd3ace0d827
    Closes-Bug: #1581159


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1581159

Title:
  ceph testing: parsing osd crush rule dump devstack output with awk is
  wrong

Status in devstack-plugin-ceph:
  Confirmed
Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  We noticed that setting up ceph with 2 replicas fails in the nova live
  migration job:

  http://logs.openstack.org/73/312773/1/experimental/gate-tempest-dsvm-
  multinode-live-migration/c57f6b9/console.html#_2016-05-08_09_18_59_103

  jbernard said the awk here needs to use $2:

  https://github.com/openstack/devstack-plugin-
  ceph/blob/master/devstack/lib/ceph#L318

  https://github.com/openstack/nova/blob/master/nova/tests/live_migration/hooks/ceph.sh#L109

  The reason the devstack ceph plugin job doesn't fail is because it
  defaults to using 1 replica, so we don't get into that block, but the
  nova live migration job uses 2 replicas, so we get into that code and
  it fails.

To manage notifications about this bug go to:
https://bugs.launchpad.net/devstack-plugin-ceph/+bug/1581159/+subscriptions


References