yahoo-eng-team team mailing list archive

[Andrew Liu <andrew.lhj@xxxxxxxxx>]

Public bug reported:

In the keystone unittest of test_v3_identity.py, there are two functions used in the IdentityTestCase,
one is assertValidUserListResponse() and another is assertValidUserResponse().

These two functions eventually used this
RestfulTestCase.assertValidUser(), and for the above two functions are
call in different style.

self.assertValidUserListResponse(r, ref=self.user, resource_url=resource_url)
self.assertValidUserResponse(r, user)

the assertValidUserListResponse() is called with named argument
"ref=self.user", but the assertValidUserResponse() is not.

Although, this won't cause any problem, but it would be better to unify
the function call.

** Affects: keystone
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1591916

Title:
  Named arguments should be used for assertValidUserResponse() in
  unittest case

Status in OpenStack Identity (keystone):
  New

Bug description:
  In the keystone unittest of test_v3_identity.py, there are two functions used in the IdentityTestCase,
  one is assertValidUserListResponse() and another is assertValidUserResponse().

  These two functions eventually used this
  RestfulTestCase.assertValidUser(), and for the above two functions are
  call in different style.

  self.assertValidUserListResponse(r, ref=self.user, resource_url=resource_url)
  self.assertValidUserResponse(r, user)

  the assertValidUserListResponse() is called with named argument
  "ref=self.user", but the assertValidUserResponse() is not.

  Although, this won't cause any problem, but it would be better to
  unify the function call.

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1591916/+subscriptions