← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1544522] Re: Don't use Mock.called_once_with that does not exist

 

Reviewed:  https://review.openstack.org/312611
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=3420886b8d24b570823cb500cf1feb9031d4a887
Submitter: Jenkins
Branch:    master

commit 3420886b8d24b570823cb500cf1feb9031d4a887
Author: stewie925 <st6218@xxxxxxx>
Date:   Wed May 4 08:37:05 2016 -0700

    Rename called_once_with methods correctly
    
    * Remove 'self.assertTrue' enclosing the '.called_once_with'
    * methods and rename '.called_once_with' method name to
    * '.assert_called_once_with'.
    
    Change-Id: I04d1c99df9983733b6d2579ba71097b2cebc6a54
    Closes-Bug: #1544522


** Changed in: trove
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1544522

Title:
  Don't use Mock.called_once_with that does not exist

Status in Cinder:
  Fix Released
Status in neutron:
  Fix Released
Status in octavia:
  Fix Released
Status in python-designateclient:
  Fix Released
Status in python-openstackclient:
  Fix Released
Status in Rally:
  Fix Released
Status in Sahara:
  Fix Released
Status in OpenStack DBaaS (Trove):
  Fix Released

Bug description:
  class mock.Mock does not exist method "called_once_with", it just
  exists method "assert_called_once_with". Currently there are still
  some places where we use called_once_with method, we should correct
  it.

  NOTE: called_once_with() does nothing because it's a mock object.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1544522/+subscriptions