yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #52327
[Bug 1582790] Re: Selecting first option in transfer table confuses styling
Reviewed: https://review.openstack.org/317598
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=180bcf23748d1f7661565c623c61773fb481e088
Submitter: Jenkins
Branch: master
commit 180bcf23748d1f7661565c623c61773fb481e088
Author: Matt Borland <matt.borland@xxxxxxx>
Date: Tue May 17 09:57:37 2016 -0600
Correcting detail-row logic to not disrupt styling
The detail-rows on source and flavor transfer tables get styling confused
when items are selected because their detail-row elements remain and thus
confuse the alternate styling. This patch fixes both of those tables
to exclude the detail-row when the primary row is also excluded.
Test this by (before the patch) selecting, say, the first option from the
available and see how the styling screws up on the remaining ones. Then
apply the patch and see how everything looks beautiful.
Change-Id: Ia19fd4b47ea08c28dfb95c369b6b3f7271420f04
Closes-Bug: 1582790
** Changed in: horizon
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1582790
Title:
Selecting first option in transfer table confuses styling
Status in OpenStack Dashboard (Horizon):
Fix Released
Bug description:
If you go to the Launch Instance wizard and select the first available
option, for example in Source, you'll see the table-striping styling
gets messed up (if you have the striping patch). This is because the
markup improperly lets the unshown details row be presented; this
needs to be restricted similarly to the primary row.
To test the problem, verify that the Source option stripes rows
properly when nothing is selected. Then select the first option. See
how the rows now are formatted similarly (not striped).
To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1582790/+subscriptions
References