yahoo-eng-team team mailing list archive

[OpenStack Infra <1583601@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/318981
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=387283d8de81fa4c7e28bc41d6c7707a388aeeef
Submitter: Jenkins
Branch:    master

commit 387283d8de81fa4c7e28bc41d6c7707a388aeeef
Author: Hong Hui Xiao <xiaohhui@xxxxxxxxxx>
Date:   Thu May 19 13:12:06 2016 +0000

    Prevent adding duplicated sg rules with diff description
    
    Now the security group rules can be added with same content but different
    description. This should be prevented to stop creating duplicated sg rules.
    
    Change-Id: Ibafe39f9652ecd24ad9536e6abc7c4f4384b3a22
    Closes-bug: #1583601


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1583601

Title:
  Duplicated sg rules could be created with diff description

Status in neutron:
  Fix Released

Bug description:
  I can create multiple security group rules with same content, but different descriptions.
  For example,

  [fedora@normal2 ~]$ neutron security-group-rule-create test --protocol tcp --remote-group-id 1b8c08e5-728d-48ef-a24b-e4ebc20808a3
  Created a new security_group_rule:
  +-------------------+--------------------------------------+
  | Field             | Value                                |
  +-------------------+--------------------------------------+
  | description       |                                      |
  | direction         | ingress                              |
  | ethertype         | IPv4                                 |
  | id                | 09eaa983-7884-4c27-bffb-81064d164688 |
  | port_range_max    |                                      |
  | port_range_min    |                                      |
  | protocol          | tcp                                  |
  | remote_group_id   | 1b8c08e5-728d-48ef-a24b-e4ebc20808a3 |
  | remote_ip_prefix  |                                      |
  | security_group_id | db8d1386-0b2e-4f0c-b4c2-16c10b30fd92 |
  | tenant_id         | 02178a7c126a4066ab5c3fae571d89c8     |
  +-------------------+--------------------------------------+
  [fedora@normal2 ~]$ neutron security-group-rule-create test --protocol tcp --remote-group-id 1b8c08e5-728d-48ef-a24b-e4ebc20808a3 --description "123"
  Created a new security_group_rule:
  +-------------------+--------------------------------------+
  | Field             | Value                                |
  +-------------------+--------------------------------------+
  | description       | 123                                  |
  | direction         | ingress                              |
  | ethertype         | IPv4                                 |
  | id                | 5282599c-4262-4c48-b999-052a0ce5cff7 |
  | port_range_max    |                                      |
  | port_range_min    |                                      |
  | protocol          | tcp                                  |
  | remote_group_id   | 1b8c08e5-728d-48ef-a24b-e4ebc20808a3 |
  | remote_ip_prefix  |                                      |
  | security_group_id | db8d1386-0b2e-4f0c-b4c2-16c10b30fd92 |
  | tenant_id         | 02178a7c126a4066ab5c3fae571d89c8     |
  +-------------------+--------------------------------------+

  This should be prevented.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1583601/+subscriptions