← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1592553] Re: Port Validator Failing

 

Reviewed:  https://review.openstack.org/329777
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=68ce548f8193e1b29475f1ed4d0d6c2506a1ffab
Submitter: Jenkins
Branch:    master

commit 68ce548f8193e1b29475f1ed4d0d6c2506a1ffab
Author: Matthias Runge <mrunge@xxxxxxxxxx>
Date:   Wed Jun 15 08:48:45 2016 +0200

    Fix port validator
    
    A recent change in netutils now allows a port number 0
    as valid port number. This made tests fail.
    
    Change-Id: Ic290b76daa59387d8a13ce3712f7cd9416ac80c5
    Closes-bug: #1592553


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1592553

Title:
  Port Validator Failing

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  A recent update to netutils allows users to select port number 0. This
  change is causing the below to fail.

  ======================================================================
  FAIL: test_port_range_validator (horizon.test.tests.utils.ValidatorsTests)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/opt/stack/horizon/horizon/test/tests/utils.py", line 257, in test_port_range_validator
      self.assertRaises(ValidationError, test_call, prange)
  AssertionError: ValidationError not raised

  
  ======================================================================
  FAIL: test_port_validator (horizon.test.tests.utils.ValidatorsTests)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/opt/stack/horizon/horizon/test/tests/utils.py", line 207, in test_port_validator
      port)
  AssertionError: ValidationError not raised

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1592553/+subscriptions


References