← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1592849] [NEW] XenAPI: Invalid domid detection incorrect

 

Public bug reported:

https://git.openstack.org/cgit/openstack/nova/tree/nova/virt/xenapi/vmops.py#n2048

    def _get_dom_id(self, instance=None, vm_ref=None, check_rescue=False):
        vm_ref = vm_ref or self._get_vm_opaque_ref(instance, check_rescue)
        domid = self._session.call_xenapi("VM.get_domid", vm_ref)
        if not domid or domid == -1:
            raise exception.InstanceNotFound(instance_id=instance['name'])
        return domid

VM.get_domid will return a string, which will never be equal to an
integer.

** Affects: nova
     Importance: High
     Assignee: Bob Ball (bob-ball)
         Status: Confirmed

** Changed in: nova
   Importance: Undecided => High

** Changed in: nova
     Assignee: (unassigned) => Bob Ball (bob-ball)

** Changed in: nova
       Status: New => Confirmed

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1592849

Title:
  XenAPI: Invalid domid detection incorrect

Status in OpenStack Compute (nova):
  Confirmed

Bug description:
  https://git.openstack.org/cgit/openstack/nova/tree/nova/virt/xenapi/vmops.py#n2048

      def _get_dom_id(self, instance=None, vm_ref=None, check_rescue=False):
          vm_ref = vm_ref or self._get_vm_opaque_ref(instance, check_rescue)
          domid = self._session.call_xenapi("VM.get_domid", vm_ref)
          if not domid or domid == -1:
              raise exception.InstanceNotFound(instance_id=instance['name'])
          return domid

  VM.get_domid will return a string, which will never be equal to an
  integer.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1592849/+subscriptions


Follow ups