← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1589328] Re: Alembic branch checks do not detect Add/DropColumn violations

 

Reviewed:  https://review.openstack.org/325699
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=28bc1d79361ddbe53b67058a6c995e2d9ac19e3a
Submitter: Jenkins
Branch:    master

commit 28bc1d79361ddbe53b67058a6c995e2d9ac19e3a
Author: Henry Gessau <gessau@xxxxxxxxx>
Date:   Sun Jun 5 22:05:33 2016 -0400

    Check for alembic Add/DropColumn exceptions in migrations
    
    Columns are added/dropped by alembic clauses in migrations, and
    checking for them differs from how sqlalchemy clauses are checked.
    
    Closes-Bug: #1589328
    
    Change-Id: Ia0f39697afddec7cd04f870746a4bdd8b9410a32


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1589328

Title:
  Alembic branch checks do not detect Add/DropColumn violations

Status in neutron:
  Fix Released

Bug description:
  In the test_branches test we check that elements are not added in the
  contract branch, and that elements are not removed in the expand
  branch. However, this check is not working for Add/DropColumn because
  they are processed as alembic clauses which have no element property.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1589328/+subscriptions


References