← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1520094] Re: Retire gettext.install which installs _() as builtin namespace

 

Reviewed:  https://review.openstack.org/320772
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=19c5ec76464568252f8ca0eae28849b2797111c3
Submitter: Jenkins
Branch:    master

commit 19c5ec76464568252f8ca0eae28849b2797111c3
Author: Akihiro Motoki <amotoki@xxxxxxxxx>
Date:   Wed May 25 13:12:12 2016 +0900

    Drop neutron/i18n.py in favor of neutron/_i18n.py
    
    The hacking rule already ensures everyone uses neutron._i18n.
    Now we can drop neutron.i18n.
    
    Closes-Bug: #1520094
    Change-Id: I1a415c23fd1db103742e8f3a92a3dd26c7252233


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1520094

Title:
  Retire gettext.install which installs _() as builtin namespace

Status in neutron:
  Fix Released

Bug description:
  As oslo.i18n document [1] suggests, we need to replace _() in the
  python builtin namespaces with _ defined in _i18n.py in each module.
  Sharing _() in the builtin namespaces prevents us from looking up per-
  module translation catalogs because it forces all subprojects to use
  "neutron" domain.

  It is required to support per-project message catalog.

  Required actions:

  - Introduce _i18.py with a project specific domain as suggested by oslo.i18n.
  - Change all related project consumes _() from their own _i18n.py
  - Remove gettext.install from neutron/__init__.py.

  I will move forward this bug, but anyone can help me.
  There are many projects under neutron stadium.

  [1] http://docs.openstack.org/developer/oslo.i18n/usage.html

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1520094/+subscriptions


References