← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1594576] [NEW] cc_salt_minion behaves badly if apt-get update fails

 

Public bug reported:

I'm using cloud-init to setup some salt-minion config like so:

 #cloud-config
 salt_minion:
   conf:
     grains:
       my_grain_1: a
       my_grain_2: b

cc_salt_minion.py triggers apt-get update.  If apt-get update fails,
then cc_salt_minion does not update /etc/salt/minion, but nonetheless
continues.  My automation depends on finding these grains, and salt-
minion is already built in.

Please consider the attached patch, which will skip the install if a
flag is included.  Alternatively, cc_salt_minion could write out
/etc/salt/minion even if apt-get fails.

Ross

** Affects: cloud-init
     Importance: Undecided
         Status: New

** Patch added: "add knob to disable salt-minion installation"
   https://bugs.launchpad.net/bugs/1594576/+attachment/4687510/+files/cc-salt-minion-skip-install.diff

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to cloud-init.
https://bugs.launchpad.net/bugs/1594576

Title:
  cc_salt_minion behaves badly if apt-get update fails

Status in cloud-init:
  New

Bug description:
  I'm using cloud-init to setup some salt-minion config like so:

   #cloud-config
   salt_minion:
     conf:
       grains:
         my_grain_1: a
         my_grain_2: b

  cc_salt_minion.py triggers apt-get update.  If apt-get update fails,
  then cc_salt_minion does not update /etc/salt/minion, but nonetheless
  continues.  My automation depends on finding these grains, and salt-
  minion is already built in.

  Please consider the attached patch, which will skip the install if a
  flag is included.  Alternatively, cc_salt_minion could write out
  /etc/salt/minion even if apt-get fails.

  Ross

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-init/+bug/1594576/+subscriptions


Follow ups