← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1591766] Related fix merged to neutron (master)

 

Reviewed:  https://review.openstack.org/331424
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=877778ee4c7f0e83b54f54b2d7bafec98f89626c
Submitter: Jenkins
Branch:    master

commit 877778ee4c7f0e83b54f54b2d7bafec98f89626c
Author: Armando Migliaccio <armamig@xxxxxxxxx>
Date:   Sat Jun 18 08:19:03 2016 -0700

    Move DHCP notification logic out of API controller
    
    Bug 1591766 unveiled an issue where calling the plugin API does not trigger
    DHCP notifications. This is required by the auto-allocated-topology service
    plugin that calls core_plugin.update_network(), and expect notifications
    to be sent out on state changes. To accomplish this, the logic has been
    encapsulated in the DHCP module, and leveraged via callback mechanisms.
    
    For this reason, new events have been introduced, AFTER_REQUEST, and
    BEFORE_RESPONSE. The latter in particular is the one needed to hook up
    dhcp notifications in order to preserve backward compatibility.
    
    More precisely, core plugins that use DHCP as is or implement their own,
    (with or without an agent) should already instantiate their own notifier,
    and if they do not, this should be rectified.
    
    A search on codesearch.openstack.org reveals that out-of-tree plugins
    already specify their own notifiers, and the default initialization is
    clearly redundant now.
    
    Related-bug: #1591766
    
    Change-Id: I7440becb6d30af7159ecaeba09d7a28eceb71bea


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1591766

Title:
  auto_allocated_topology network creation isn't atomic per tenant

Status in neutron:
  Fix Released

Bug description:
  I've written a tempest test which creates 2 servers in nova which
  don't have any networking available in the tenant when the server
  create request is made. This invokes the auto_allocated_topology API
  in neutron to create the networking resources for the tenant.

  The test failed because it expects at the end that there is only one
  private network for the tenant created but in this case there were
  two:

  http://logs.openstack.org/01/327901/1/check/gate-tempest-dsvm-neutron-
  full/9972b81/console.html#_2016-06-12_15_19_25_240

  Showing that the network create wasn't atomic per tenant in concurrent
  requests from nova's compute manager.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1591766/+subscriptions


References