yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #52856
[Bug 1595819] Re: cannot create (or set) a user with no password
Reviewed: https://review.openstack.org/333919
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=e04c5614377a7209bde7904a37ac80e6d98bc620
Submitter: Jenkins
Branch: master
commit e04c5614377a7209bde7904a37ac80e6d98bc620
Author: Ronald De Rose <ronald.de.rose@xxxxxxxxx>
Date: Fri Jun 24 14:06:06 2016 +0000
Fixes failure when password is null
This patch allows the password column to be null which is the expected
behavior.
Note: We do have tests in place that should have caught this. However,
the SQL model for Password did not explicitly set the nullable column
attribute, so it defaulted to true, even though the migration set it to
false.
Closes-Bug: #1595819
Change-Id: I487072a5b1aeabebd1d2006781fa5dc568160ec5
** Changed in: keystone
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1595819
Title:
cannot create (or set) a user with no password
Status in heat:
New
Status in OpenStack Identity (keystone):
Fix Released
Bug description:
It seems the gate is broken with AutoScalingSignaltest faling.
I suspect this is due to the recent keystone change https://review.openstack.org/#/c/314284/
keystone error traceback:
2016-06-24 03:34:02.273 8966 ERROR oslo_db.sqlalchemy.exc_filters
[req-99ad876c-6f1f-4742-8dcf-52d461fa0c9f
16a1dbfadccd44a3813a0e097a61ac25 - a08006a9c7c84f5ca7afaed59ac8e7a5
a08006a9c7c84f5ca7afaed59ac8e7a5 -] DBAPIError exception wrapped from
(pymysql.err.IntegrityError) (1048, u"Column 'password' cannot be
null") [SQL: u'INSERT INTO password (local_user_id, password,
created_at, expires_at) VALUES (%(local_user_id)s, %(password)s,
%(created_at)s, %(expires_at)s)'] [parameters: {'local_user_id': 36,
'password': None, 'created_at': datetime.datetime(2016, 6, 24, 3, 34,
2, 269022), 'expires_at': None}]
heat engine traceback:
http://logs.openstack.org/76/333676/1/check/gate-heat-dsvm-functional-
orig-mysql-
lbaasv2/516afaa/logs/screen-h-eng.txt.gz#_2016-06-24_03_34_02_280
b2c8-e27e2a774982]
2016-06-24 03:34:02.280 4863 ERROR heat.engine.resource Traceback (most recent call last):
2016-06-24 03:34:02.280 4863 ERROR heat.engine.resource File "/opt/stack/new/heat/heat/engine/resource.py", line 716, in _action_recorder
2016-06-24 03:34:02.280 4863 ERROR heat.engine.resource yield
2016-06-24 03:34:02.280 4863 ERROR heat.engine.resource File "/opt/stack/new/heat/heat/engine/resource.py", line 796, in _do_action
2016-06-24 03:34:02.280 4863 ERROR heat.engine.resource yield self.action_handler_task(action, args=handler_args)
2016-06-24 03:34:02.280 4863 ERROR heat.engine.resource File "/opt/stack/new/heat/heat/engine/scheduler.py", line 312, in wrapper
2016-06-24 03:34:02.280 4863 ERROR heat.engine.resource step = next(subtask)
2016-06-24 03:34:02.280 4863 ERROR heat.engine.resource File "/opt/stack/new/heat/heat/engine/resource.py", line 759, in action_handler_task
2016-06-24 03:34:02.280 4863 ERROR heat.engine.resource handler_data = handler(*args)
2016-06-24 03:34:02.280 4863 ERROR heat.engine.resource File "/opt/stack/new/heat/heat/engine/resources/stack_user.py", line 110, in handle_suspend
2016-06-24 03:34:02.280 4863 ERROR heat.engine.resource user_id=user_id, project_id=self.stack.stack_user_project_id)
2016-06-24 03:34:02.280 4863 ERROR heat.engine.resource File "/opt/stack/new/heat/heat/engine/clients/os/keystone/heat_keystoneclient.py", line 528, in disable_stack_domain_user
2016-06-24 03:34:02.280 4863 ERROR heat.engine.resource self.domain_admin_client.users.update(user=user_id, enabled=False)
2016-06-24 03:34:02.280 4863 ERROR heat.engine.resource File "/usr/local/lib/python2.7/dist-packages/debtcollector/renames.py", line 43, in decorator
2016-06-24 03:34:02.280 4863 ERROR heat.engine.resource return wrapped(*args, **kwargs)
2016-06-24 03:34:02.280 4863 ERROR heat.engine.resource File "/usr/local/lib/python2.7/dist-packages/positional/__init__.py", line 101, in inner
2016-06-24 03:34:02.280 4863 ERROR heat.engine.resource return wrapped(*args, **kwargs)
2016-06-24 03:34:02.280 4863 ERROR heat.engine.resource File "/usr/local/lib/python2.7/dist-packages/keystoneclient/v3/users.py", line 209, in update
2016-06-24 03:34:02.280 4863 ERROR heat.engine.resource log=False)
2016-06-24 03:34:02.280 4863 ERROR heat.engine.resource File "/usr/local/lib/python2.7/dist-packages/keystoneclient/base.py", line 227, in _update
2016-06-24 03:34:02.280 4863 ERROR heat.engine.resource **kwargs)
2016-06-24 03:34:02.280 4863 ERROR heat.engine.resource File "/usr/local/lib/python2.7/dist-packages/keystoneauth1/adapter.py", line 190, in patch
2016-06-24 03:34:02.280 4863 ERROR heat.engine.resource return self.request(url, 'PATCH', **kwargs)
2016-06-24 03:34:02.280 4863 ERROR heat.engine.resource File "/usr/local/lib/python2.7/dist-packages/keystoneauth1/adapter.py", line 335, in request
2016-06-24 03:34:02.280 4863 ERROR heat.engine.resource resp = super(LegacyJsonAdapter, self).request(*args, **kwargs)
2016-06-24 03:34:02.280 4863 ERROR heat.engine.resource File "/usr/local/lib/python2.7/dist-packages/keystoneauth1/adapter.py", line 103, in request
2016-06-24 03:34:02.280 4863 ERROR heat.engine.resource return self.session.request(url, method, **kwargs)
2016-06-24 03:34:02.280 4863 ERROR heat.engine.resource File "/usr/local/lib/python2.7/dist-packages/positional/__init__.py", line 101, in inner
2016-06-24 03:34:02.280 4863 ERROR heat.engine.resource return wrapped(*args, **kwargs)
2016-06-24 03:34:02.280 4863 ERROR heat.engine.resource File "/usr/local/lib/python2.7/dist-packages/keystoneauth1/session.py", line 487, in request
2016-06-24 03:34:02.280 4863 ERROR heat.engine.resource raise exceptions.from_response(resp, method, url)
2016-06-24 03:34:02.280 4863 ERROR heat.engine.resource InternalServerError: An unexpected error prevented the server from fulfilling your request. (HTTP 500) (Request-ID: req-99ad876c-6f1f-4742-8dcf-52d461fa0c9f)
To manage notifications about this bug go to:
https://bugs.launchpad.net/heat/+bug/1595819/+subscriptions