yahoo-eng-team team mailing list archive

[OpenStack Infra <1596466@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/334369
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=797f823c6ee3a8243996b5f9df08f4c5de2c4f07
Submitter: Jenkins
Branch:    master

commit 797f823c6ee3a8243996b5f9df08f4c5de2c4f07
Author: Yves-Gwenael Bourhis <yves-gwenael.bourhis@xxxxxxxxxxxxx>
Date:   Mon Jun 27 11:30:21 2016 +0200

    Never import setting from openstack_dashboard
    
    Unittests have their own settings and should not source openstack_dashboard
    settings.
    It is commonly known that django code should always import settings via
    "from django.conf import settings".
    
    Change-Id: I4fb5f68ed9595c5f785437b863e2eef7f6ab23c1
    Closes-Bug: #1596466


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1596466

Title:
  unitests fail with the presence of a local_settings file

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  The following patch broke stable/mitaka and master unittests because
  the custom local_settings file is sourced and should not:

  https://review.openstack.org/#/q/I05c8fc750c56f6f6bb49a435662e821eb0d6ba30,n,z

  this is because we should have "from django.conf import settings"
  instead of "from openstack_dashboard import settings".

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1596466/+subscriptions