← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1596873] [NEW] [novncproxy] log for closing web is misleading

 

Public bug reported:

Description
===========
When user close console web, log will record "Target closed vmsg".
In fact, Target is not closed.

Steps to reproduce
==================
close web console windows

Expected result
===============
the log shows  "Webclient closed vmsg"

Actual result
=============
the log shows  "Target closed vmsg"

Environment
===========
openstack-nova-novncproxy-13.0.0.0-1

Related code
==============
file:nova/console/websocketproxy.py
function:NovaProxyRequestHandlerBase::new_websocket_client
...........................................
        # Start proxying
        try:
            self.do_proxy(tsock)
        except Exception:
            if tsock:
                tsock.shutdown(socket.SHUT_RDWR)
                tsock.close()
                self.vmsg(_("%(host)s:%(port)s: Target closed") %
                          {'host': host, 'port': port})
            raise

** Affects: nova
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1596873

Title:
  [novncproxy] log for closing web is misleading

Status in OpenStack Compute (nova):
  New

Bug description:
  Description
  ===========
  When user close console web, log will record "Target closed vmsg".
  In fact, Target is not closed.

  Steps to reproduce
  ==================
  close web console windows

  Expected result
  ===============
  the log shows  "Webclient closed vmsg"

  Actual result
  =============
  the log shows  "Target closed vmsg"

  Environment
  ===========
  openstack-nova-novncproxy-13.0.0.0-1

  Related code
  ==============
  file:nova/console/websocketproxy.py
  function:NovaProxyRequestHandlerBase::new_websocket_client
  ...........................................
          # Start proxying
          try:
              self.do_proxy(tsock)
          except Exception:
              if tsock:
                  tsock.shutdown(socket.SHUT_RDWR)
                  tsock.close()
                  self.vmsg(_("%(host)s:%(port)s: Target closed") %
                            {'host': host, 'port': port})
              raise

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1596873/+subscriptions


Follow ups