yahoo-eng-team team mailing list archive

[Hiroyuki Eguchi <1598661@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

A year ago I fixed a bug: https://review.openstack.org/#/c/195885/
The launchpad report: https://bugs.launchpad.net/nova/+bug/1469006

A above patch makes live-migration enable when instance is booted volume
and has not local disk.

A above patch performs the check via a call of _is_booted_from_volume and
check the result if other checks (check_dest_data['is_shared_block_storage']) fails.

However, this check has been already checked in _is_shared_block_storage
method.

The last part of the _is_shared_block_storage method does the same that above patch does:
 - check whether the instance is booted from volume.
 - check whether the instance has not a local disk.

** Affects: nova
     Importance: Undecided
     Assignee: Hiroyuki Eguchi (h-eguchi)
         Status: New

** Changed in: nova
     Assignee: (unassigned) => Hiroyuki Eguchi (h-eguchi)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1598661

Title:
  Delete duplicate check when live-migrating

Status in OpenStack Compute (nova):
  New

Bug description:
  A year ago I fixed a bug: https://review.openstack.org/#/c/195885/
  The launchpad report: https://bugs.launchpad.net/nova/+bug/1469006

  A above patch makes live-migration enable when instance is booted
  volume and has not local disk.

  A above patch performs the check via a call of _is_booted_from_volume and
  check the result if other checks (check_dest_data['is_shared_block_storage']) fails.

  However, this check has been already checked in
  _is_shared_block_storage method.

  The last part of the _is_shared_block_storage method does the same that above patch does:
   - check whether the instance is booted from volume.
   - check whether the instance has not a local disk.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1598661/+subscriptions