yahoo-eng-team team mailing list archive

[OpenStack Infra <1586268@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/337031
Committed: https://git.openstack.org/cgit/openstack/python-heatclient/commit/?id=4c2a88b95905ab724a5fff5b19ff10c1ca43f4a3
Submitter: Jenkins
Branch:    master

commit 4c2a88b95905ab724a5fff5b19ff10c1ca43f4a3
Author: yuyafei <yu.yafei@xxxxxxxxxx>
Date:   Mon Jul 4 16:17:51 2016 +0800

    base.Resource not define __ne__() built-in function
    
    Class base.Resource defines __eq__() built-in function, but does
    not define __ne__() built-in function, so self.assertEqual works
    but self.assertNotEqual does not work at all in this test case in
    python2. This patch fixes it by defining __eq__() built-in function
    of class base.Resource.
    
    Change-Id: I13ed9ddd6ae6ef074232b33695916bc83930dcf0
    Closes-Bug: #1586268


** Changed in: python-heatclient
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1586268

Title:
  Unit test: self.assertNotEqual in  unit.test_base.BaseTest.test_eq
  does not work in PY2

Status in Ceilometer:
  New
Status in Cinder:
  New
Status in daisycloud-core:
  New
Status in Glance:
  New
Status in heat:
  New
Status in OpenStack Dashboard (Horizon):
  New
Status in OpenStack Identity (keystone):
  New
Status in keystonemiddleware:
  New
Status in neutron:
  New
Status in OpenStack Compute (nova):
  In Progress
Status in python-barbicanclient:
  New
Status in python-ceilometerclient:
  In Progress
Status in python-cinderclient:
  In Progress
Status in python-congressclient:
  New
Status in python-glanceclient:
  New
Status in python-heatclient:
  Fix Released
Status in python-keystoneclient:
  New
Status in python-manilaclient:
  New
Status in python-muranoclient:
  New
Status in python-novaclient:
  In Progress
Status in python-smaugclient:
  New
Status in python-swiftclient:
  New
Status in python-troveclient:
  New
Status in Rally:
  New
Status in OpenStack Object Storage (swift):
  New
Status in tempest:
  New

Bug description:
  Version: master(20160527)

  In case cinderclient.tests.unit.test_base.BaseTest.test_eq self.assertNotEqual does not work.
  Class base.Resource defines __eq__() built-in function, but does not define __ne__() built-in function, so self.assertEqual works but self.assertNotEqual does not work at all in this test case.

  steps:
  1 Clone code of python-cinderclient from master.
  2 Modify the case of unit test: cinderclient/tests/unit/test_base.py
    line50--line62.
      def test_eq(self):
          # Two resources with same ID: never equal if their info is not equal
          r1 = base.Resource(None, {'id': 1, 'name': 'hi'})
          r2 = base.Resource(None, {'id': 1, 'name': 'hello'})
          self.assertNotEqual(r1, r2)

          # Two resources with same ID: equal if their info is equal
          r1 = base.Resource(None, {'id': 1, 'name': 'hello'})
          r2 = base.Resource(None, {'id': 1, 'name': 'hello'})
          # self.assertEqual(r1, r2)
          self.assertNotEqual(r1, r2)

          # Two resoruces of different types: never equal
          r1 = base.Resource(None, {'id': 1})
          r2 = volumes.Volume(None, {'id': 1})
          self.assertNotEqual(r1, r2)

          # Two resources with no ID: equal if their info is equal
          r1 = base.Resource(None, {'name': 'joe', 'age': 12})
          r2 = base.Resource(None, {'name': 'joe', 'age': 12})
          # self.assertEqual(r1, r2)
          self.assertNotEqual(r1, r2)

     Modify self.assertEqual(r1, r2) to self.assertNotEqual(r1, r2).

  3 Run unit test, and return success.

  After that, I make a test:

  class Resource(object):
      def __init__(self, person):
          self.person = person

      def __eq__(self, other):
          return self.person == other.person

  r1 = Resource("test")
  r2 = Resource("test")
  r3 = Resource("test_r3")
  r4 = Resource("test_r4")

  print r1 != r2
  print r1 == r2
  print r3 != r4
  print r3 == r4

  The result is :
  True
  True
  True
  False

  Whether r1 is precisely the same to r2 or not, self.assertNotEqual(r1,
  r2) return true.So I think self.assertNotEqual doesn't work at all in
  python2 and  should be modified.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ceilometer/+bug/1586268/+subscriptions