yahoo-eng-team team mailing list archive

[OpenStack Infra <1597823@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/336107
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=eb60a8b2874a348fec104672ce7d5d991faa3d47
Submitter: Jenkins
Branch:    master

commit eb60a8b2874a348fec104672ce7d5d991faa3d47
Author: Matt Borland <matt.borland@xxxxxxx>
Date:   Thu Jun 30 10:17:46 2016 -0600

    Use absUrl, so WEBROOT isn't ignored on redirect
    
    For the 'fall-through' condition for Angular routing, it will
    simply redirect to the URL wanted.  Basically, Angular says: "If
    I don't know this URL in my internal routing, it's outside the
    single-page-app and needs to be pulled from the server."  However,
    the code uses the general Angular path, which does NOT include
    the base tag's prefix, meaning in a situation where WEBROOT is set
    to other than '/' it will not include the base value, and route to
    a non-WEBROOTed path.  Using absUrl correctly uses the full path.
    
    Change-Id: Idbf91bd5913937788bf31bcf1d389c590dd3e2d7
    Closes-Bug: 1597823


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1597823

Title:
  Angular fall-through redirection doesn't use WEBROOT

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  When on an Angular page and using the fall-through routing (routing
  from an Angular page back to a Django page using Angular relative
  paths), the redirect doesn't respect WEBROOT.

  This is best seen when using relative links in URLs, like in
  Searchlight panels and linking to internal pages, only when WEBROOT is
  other than '/'.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1597823/+subscriptions