← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1563101] Fix merged to keystone (master)

 

Reviewed:  https://review.openstack.org/339112
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=5d707d510daa7ae0784fffd2cf45a9ee8906821f
Submitter: Jenkins
Branch:    master

commit 5d707d510daa7ae0784fffd2cf45a9ee8906821f
Author: Ronald De Rose <ronald.de.rose@xxxxxxxxx>
Date:   Thu Jul 7 16:19:28 2016 +0000

    Move the auth plugins abstract base class out of core
    
    This patch moves the auth plugins abstract base class out of core and
    into plugins/base.py
    
    This removes dependencies where backend code references code in the
    core. The reasoning being that the core should know about the backend
    interface, but the backends should not know anything about the core
    (separation of concerns). And part of the risk here is a potential for
    circular dependencies.
    
    Partial-Bug: #1563101
    
    Change-Id: I4413ef01523d02c30af97e306069229252cb4971


** Changed in: keystone
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1563101

Title:
  Remove backend dependency on core

Status in OpenStack Identity (keystone):
  Fix Released

Bug description:
  Remove dependencies where backend code references code in the core.  For example, identity backends imports identity:
  https://github.com/openstack/keystone/blob/stable/mitaka/keystone/identity/backends/sql.py#L24

  The reasoning being that the core should know about the backend
  interface, but the backends should not know anything about the core
  (separation of concerns).

  And part of the risk here is a potential for circular dependencies.
  Backend code could reference code in the core, as well as other higher
  level modules inside identity; thus, creating a circular dependency.

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1563101/+subscriptions


References