← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1583419] Re: Make dict.keys() PY3 compatible

 

Reviewed:  https://review.openstack.org/337440
Committed: https://git.openstack.org/cgit/openstack/tacker/commit/?id=df7c0dad5ba45bc5122ebc2fe2aa3f4330d57a55
Submitter: Jenkins
Branch:    master

commit df7c0dad5ba45bc5122ebc2fe2aa3f4330d57a55
Author: qinchunhua <qin.chunhua@xxxxxxxxxx>
Date:   Tue Jul 5 02:01:20 2016 -0400

    Fix dict.keys() PY3 compatible
    
    The dict.keys()[0] will raise a TypeError in PY3,
    as dict.keys() doesn't return a list any more in PY3
    but a view of list.
    
    Change-Id: I99514d57cb21bf65a59eb36b556248b9494246c7
    Closes-Bug: #1583419


** Changed in: tacker
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1583419

Title:
  Make dict.keys() PY3 compatible

Status in Cinder:
  Fix Released
Status in neutron:
  In Progress
Status in python-cinderclient:
  Fix Released
Status in python-manilaclient:
  Fix Released
Status in python-troveclient:
  Fix Released
Status in Rally:
  Fix Released
Status in tacker:
  Fix Released
Status in tempest:
  In Progress

Bug description:
  In PY3, dict.keys() will return a view of list but not a list anymore, i.e.
  $ python3.4
  Python 3.4.3 (default, Mar 31 2016, 20:42:37) 
  >>> body={"11":"22"}
  >>> body[body.keys()[0]]
  Traceback (most recent call last):
    File "<stdin>", line 1, in <module>
  TypeError: 'dict_keys' object does not support indexing

  so for py3 compatible we should change it as follows:
  >>> body[list(body.keys())[0]]
  '22'

To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1583419/+subscriptions