← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1600352] Re: Launch Instance from NG Images fails on first attempt

 

Reviewed:  https://review.openstack.org/339793
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=7b95e2a065df4ca3ed6b302f12ee9daa0c5948fc
Submitter: Jenkins
Branch:    master

commit 7b95e2a065df4ca3ed6b302f12ee9daa0c5948fc
Author: Matt Borland <matt.borland@xxxxxxx>
Date:   Fri Jul 8 13:42:20 2016 -0600

    Magic-Search isn't rendered unless config is ready
    
    This patch alleviates a problem where sometimes the magic-search element
    needs to be rendered, but the configuration isn't ready yet.  This simply
    skips the rendering unless the primary configuration parameters are in place.
    
    This is evident when Launch Instance is launched via an item action, such as
    within the Image items.
    
    Change-Id: I10452428e2d17cd17c98c65cbf8147dc7ab14621
    Closes-Bug: 1600352


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1600352

Title:
  Launch Instance from NG Images fails on first attempt

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Consistently, Launch Instance from the Angular Images panel fails on
  first attempt.

  This is because magic-search relies on elements being present that
  aren't always initialized right away.  It's OK, the lifecycle will
  catch up, but at first we need to exclude rendering the magic-search
  when it's not ready.

  You can recreate this by enabling Angular Images panel:

  enabled via:
  ./openstack_dashboard/enabled/_1051_project_ng_images_panel.py

  Go to the panel, then (the first time only) with the JS console open,
  try to launch an instance from an image in its item actions.  Notice
  a) how there are errors in the console and b) how there is Angular
  crud on many of the steps using magic-search.

  Apply the fix, and see how (a) and (b) are no longer present.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1600352/+subscriptions


References