← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1259292] Re: Some tests use assertEqual(observed, expected) , the argument order is wrong

 

Reviewed:  https://review.openstack.org/340654
Committed: https://git.openstack.org/cgit/openstack-dev/pbr/commit/?id=3438c2b8ad67543638713dec1d307e558ce57980
Submitter: Jenkins
Branch:    master

commit 3438c2b8ad67543638713dec1d307e558ce57980
Author: weiweigu <gu.weiwei@xxxxxxxxxx>
Date:   Tue Jul 12 12:27:32 2016 +0800

    Fix argument order for assertEqual to (expected, observed)
    
    assertEqual expects that the arguments provided to it should be
    (expected, observed). If a particluar order is kept as a convention,
    then it helps to provide a cleaner message to the developer if Unit
    Tests fail. The following patch fixes this issue.
    
    TrivialFix
    Closes-Bug: #1259292
    
    Change-Id: I03c414a763b2d51210aaec362405912f29850e36


** Changed in: pbr
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1259292

Title:
  Some tests use assertEqual(observed, expected) , the argument order is
  wrong

Status in Astara:
  Fix Released
Status in Barbican:
  In Progress
Status in Blazar:
  New
Status in Ceilometer:
  Invalid
Status in Cinder:
  Fix Released
Status in congress:
  Fix Released
Status in daisycloud-core:
  New
Status in Designate:
  Fix Released
Status in Freezer:
  In Progress
Status in Glance:
  Fix Released
Status in glance_store:
  Fix Released
Status in Higgins:
  New
Status in OpenStack Dashboard (Horizon):
  In Progress
Status in OpenStack Identity (keystone):
  Fix Released
Status in Magnum:
  Fix Released
Status in Manila:
  Fix Released
Status in Mistral:
  Fix Released
Status in Murano:
  Fix Released
Status in networking-calico:
  New
Status in networking-infoblox:
  In Progress
Status in networking-l2gw:
  In Progress
Status in networking-sfc:
  Fix Released
Status in OpenStack Compute (nova):
  Won't Fix
Status in os-brick:
  Fix Released
Status in PBR:
  Fix Released
Status in pycadf:
  New
Status in python-barbicanclient:
  In Progress
Status in python-ceilometerclient:
  Invalid
Status in python-cinderclient:
  Fix Released
Status in python-designateclient:
  Fix Committed
Status in python-glanceclient:
  Fix Released
Status in python-mistralclient:
  Fix Released
Status in python-solumclient:
  Fix Released
Status in Python client library for Zaqar:
  Fix Released
Status in Rally:
  New
Status in Sahara:
  Fix Released
Status in Solum:
  Fix Released
Status in sqlalchemy-migrate:
  New
Status in SWIFT:
  New
Status in tacker:
  In Progress
Status in tempest:
  Invalid
Status in zaqar:
  Fix Released

Bug description:
  The test cases will produce a confusing error message if the tests
  ever fail, so this is worth fixing.

To manage notifications about this bug go to:
https://bugs.launchpad.net/astara/+bug/1259292/+subscriptions