yahoo-eng-team team mailing list archive

[OpenStack Infra <1602044@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/340629
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b644a0de07ccbaa2561739831ebb0f9c0d929512
Submitter: Jenkins
Branch:    master

commit b644a0de07ccbaa2561739831ebb0f9c0d929512
Author: ghanshyam <ghanshyam.mann@xxxxxxxxxxxxxxxxxx>
Date:   Tue Jul 12 09:50:40 2016 +0900

    Fix PUT server tag 201 to return empty content
    
    Update server tag API (PUT /servers/{server_id}/tags/{tag})
    return the 201 and 204 success code if tag is created or
    already exist respectively.
    
    But in former case, API return response body with plain text-
    
    '{"code": "201 Created", "message": "<br /><br />\\n\\n\\n", "title": "Created"}'
    
    This is because it use webob.exc to generate 201. This kind
    of response body may break parsing of the data for content type.
    Also this is consistent with other nova API.
    
    webob.Response is the right choice to generate 201 without content.
    
    Change-Id: Ib0958a7a99d866a38485715b5b613914e60ad425
    Closes-Bug: #1602044


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1602044

Title:
  Update server tag return plain text in response body instead of empty
  content

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  update server tag API (PUT /servers/{server_id}/tags/{tag}) return the
  201 and 204 success code if tag is created or already exist
  respectively.

  But in former case, API return response body with plain text-

  '{"code": "201 Created", "message": "<br /><br />\\n\\n\\n", "title":
  "Created"}'

  This is because it use webob.exc to generate 201. This kind of
  response body will break while parsing the data for content type. Also
  this is consistent with other nova API.

  webob.Response is the right choice to generate 201 without content.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1602044/+subscriptions