yahoo-eng-team team mailing list archive

[OpenStack Infra <1598985@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/337319
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=9c03d6b4531a208c8af64c14046c09a598e724dd
Submitter: Jenkins
Branch:    master

commit 9c03d6b4531a208c8af64c14046c09a598e724dd
Author: Marc Abramowitz <marc@xxxxxxxxxxxxxxxxxxx>
Date:   Mon Jul 4 09:40:27 2016 -0700

    glance-replicator: compare: Show image name in msg
    
    For `glance-replicator compare`, show the image name in `entirely
    missing from the destination` warnings. The image name is more
    meaningful to humans than the image id.
    
    Closes-Bug: #1598985
    
    Change-Id: I0c8b5984b6b538c7eb0ef15e4b12f5d210fa2d4f


** Changed in: glance
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1598985

Title:
  glance-replicator compare output should show image name in addition to
  image id for missing images

Status in Glance:
  Fix Released

Bug description:
  For `glance-replicator compare`, I think we should show the image name in `entirely
  missing from the destination` warnings. The image name is more
  meaningful to humans than the image id.

  E.g: Instead of:

  ```
  $ glance-replicator --mastertoken $PRIMARY_AUTH_TOKEN --slavetoken $SECONDARY_AUTH_TOKEN compare az2:9292,az3:9292
  2016-07-04 09:36:00.594 26975 WARNING glance.cmd.replicator [-] Image e5297e33-49da-4ee3-9153-95151b30215c entirely missing from the destination
  2016-07-04 09:36:00.658 26975 WARNING glance.cmd.replicator [-] Image 63526d83-b4f6-4d7d-ab6a-312464cd9107 entirely missing from the destination
  2016-07-04 09:36:00.720 26975 WARNING glance.cmd.replicator [-] Image c2e526ed-262c-4994-a124-f29dfcf76c1f entirely missing from the destination
  ...
  ```

  I propose that it display:

  After:

  ```
  $ glance-replicator --mastertoken $PRIMARY_AUTH_TOKEN --slavetoken $SECONDARY_AUTH_TOKEN compare az2:9292,az3:9292
  2016-07-04 09:40:10.463 28055 WARNING glance.cmd.replicator [-] Image e5297e33-49da-4ee3-9153-95151b30215c ("Koala.2016-07-01-175") entirely missing from the destination
  2016-07-04 09:40:10.524 28055 WARNING glance.cmd.replicator [-] Image 63526d83-b4f6-4d7d-ab6a-312464cd9107 ("Koala.2016-07-01-174") entirely missing from the destination
  2016-07-04 09:40:10.581 28055 WARNING glance.cmd.replicator [-] Image c2e526ed-262c-4994-a124-f29dfcf76c1f ("Koala.2016-07-01-172") entirely missing from the destination
  ...
  ```

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1598985/+subscriptions