← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1596158] Re: firewall rule add "reject" action db upgrade script doesn't work for postgresql

 

Reviewed:  https://review.openstack.org/337963
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=c113550f389e1336740a3a0087a2aee73565edcb
Submitter: Jenkins
Branch:    master

commit c113550f389e1336740a3a0087a2aee73565edcb
Author: root <tian.mingming@xxxxxxx>
Date:   Wed Jul 6 09:59:16 2016 +0800

    add "reject" action to firewall rule doesn't work for postgresql
    
    The original migration script use 'alter_column' to add
    'reject' action to firewall rule, but postgresql have a
    builtin ENUM type, so just altering the column won't works,
    according to https://bitbucket.org/zzzeek/alembic/issues/270/altering-enum-type.
    
    'alter_enum' was already invented for such case in neutron,
    https://github.com/openstack/neutron/blob/master/neutron/db/migration/__init__.py.
    So use 'alter_enum' instead of 'alter_column' to resolve this problem.
    
    Closes-Bug:#1596158
    
    Change-Id: I504de48d8926c88cae63ad984b489a6636eb0bd5


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1596158

Title:
  firewall rule add "reject" action db upgrade script doesn't work for
  postgresql

Status in neutron:
  Fix Released

Bug description:
  From Liberty, firewall rule add a "reject" action, but migration
  script "4b47ea298795_add_reject_rule.py" doesn't work for postgrepsql

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1596158/+subscriptions


References