yahoo-eng-team team mailing list archive

[OpenStack Infra <1493576@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/332427
Committed: https://git.openstack.org/cgit/openstack/os-cloud-config/commit/?id=b8603c8d1db01e54faa9bbe9e4d12f8d9d494e3c
Submitter: Jenkins
Branch:    master

commit b8603c8d1db01e54faa9bbe9e4d12f8d9d494e3c
Author: Andrey Kurilin <andr.kurilin@xxxxxxxxx>
Date:   Tue Jun 21 21:47:31 2016 +0300

    Fix wrong usage of novaclient
    
    novaclient.client.Client is a documented way to initialize novaclient.
    Also, it provides a backward compatible layer.
    
    Change-Id: Ibeefe215ff1405d1e6bc478fee415b530813d86c
    Closes-Bug: #1493576


** Changed in: os-cloud-config
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1493576

Title:
  Incorrect usage of python-novaclient

Status in Cinder:
  Fix Released
Status in congress:
  Fix Released
Status in OpenStack Dashboard (Horizon):
  Fix Released
Status in Manila:
  Fix Released
Status in Mistral:
  Fix Released
Status in networking-cisco:
  Fix Released
Status in os-cloud-config:
  Fix Released
Status in OpenStack DBaaS (Trove):
  Fix Released

Bug description:
  All projects should use only `novaclient.client` as entry point. It designed with some version checks and backward compatibility.
  Direct import of versioned client object(i.e. novaclient.v2.client) is a way to "shoot yourself in the foot".

  Python-novaclient's doc: http://docs.openstack.org/developer/python-
  novaclient/api.html

  Affected projects:
   - Horizon - https://github.com/openstack/horizon/blob/69d6d50ef4a26e2629643ed35ebd661e82e10586/openstack_dashboard/api/nova.py#L31

   - Manila -
  https://github.com/openstack/manila/blob/473b46f6edc511deaba88b48392b62bfbb979787/manila/compute/nova.py#L23

   - Cinder-
  https://github.com/openstack/cinder/blob/de64f5ad716676b7180365798efc3ea69a4fef0e/cinder/compute/nova.py#L23

   - Mistral - https://github.com/openstack/mistral/blob/f42b7f5f5e4bcbce8db7e7340b4cac12de3eec4d/mistral/actions/openstack/actions.py#L23
   
   - Congress - https://github.com/openstack/congress/blob/88f4a87f4899fc29e9dde6482ceb2a0e42896ece/contrib/nova/congress.py#L92

To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1493576/+subscriptions