yahoo-eng-team team mailing list archive

[OpenStack Infra <1596829@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/341309
Committed: https://git.openstack.org/cgit/openstack/networking-vsphere/commit/?id=9300f62e12cca83fdbb316e894c17f2b226677b8
Submitter: Jenkins
Branch:    master

commit 9300f62e12cca83fdbb316e894c17f2b226677b8
Author: Aman Kumar <aman.kumar3@xxxxxxx>
Date:   Tue Jul 12 23:00:21 2016 -0700

    Fix string interpolation to delayed by logging
    
    String interpolation should be delayed to be handled by the logging
    code, rather than being done at the point of the logging call.
    
    See the oslo i18n guideline.
    * http://docs.openstack.org/developer/oslo.i18n/guidelines.html
    
    References: https://review.openstack.org/#/c/339268
    
    Change-Id: Iace952cfcf8dec76f0a6bfe11693d175fa07c640
    Closes-Bug: #1596829


** Changed in: networking-vsphere
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1596829

Title:
  String interpolation should be delayed at logging calls

Status in Ceilometer:
  New
Status in Glance:
  New
Status in glance_store:
  New
Status in heat:
  New
Status in Ironic:
  New
Status in OpenStack Identity (keystone):
  New
Status in networking-vsphere:
  Fix Released
Status in neutron:
  Fix Released
Status in OpenStack Compute (nova):
  In Progress
Status in os-brick:
  Fix Released
Status in python-cinderclient:
  New
Status in python-glanceclient:
  In Progress
Status in OpenStack Object Storage (swift):
  New
Status in taskflow:
  New

Bug description:
  String interpolation should be delayed to be handled by the logging
  code, rather than being done at the point of the logging call.

  Wrong: LOG.debug('Example: %s' % 'bad')
  Right: LOG.debug('Example: %s', 'good')

  See the following guideline.

  * http://docs.openstack.org/developer/oslo.i18n/guidelines.html
  #adding-variables-to-log-messages

  The rule for it should be added to hacking checks.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ceilometer/+bug/1596829/+subscriptions