← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1600788] Re: If a common message is not being used, they should each be treated separately with respect to choosing a marker function

 

Reviewed:  https://review.openstack.org/340894
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=14ccf5986e0423a2835c2c5be8c9a1246f0db2f3
Submitter: Jenkins
Branch:    master

commit 14ccf5986e0423a2835c2c5be8c9a1246f0db2f3
Author: weiweigu <gu.weiwei@xxxxxxxxxx>
Date:   Tue Jul 12 21:12:04 2016 +0800

    Replace "LOG.warn(_" with "LOG.(_LW"
    
    Follow http://docs.openstack.org/developer/oslo.i18n/guidelines.html:
    If a common message is not being used, they should each betreated
    separately with respect to choosing a marker function.So this patch
    is to fix it.
    
    Change-Id: Id122aa6395c534bee5287264c8951181f08d6f19
    Closes-Bug: #1600788


** Changed in: glance
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1600788

Title:
  If a common message is not being used, they should each be treated
  separately with respect to choosing a marker function

Status in Ceilometer:
  In Progress
Status in Glance:
  Fix Released
Status in glance_store:
  In Progress
Status in OpenStack Dashboard (Horizon):
  New
Status in OpenStack Identity (keystone):
  New
Status in neutron:
  Triaged
Status in oslo.log:
  Fix Released
Status in Solum:
  New

Bug description:
  Follow the
  http://docs.openstack.org/developer/oslo.i18n/guidelines.html

  For example, do not do this:

  # WRONG
  LOG.exception(_('There was an error.'))
  raise LocalExceptionClass(_('An error occured.'))
  Instead, use this style:

  # RIGHT
  LOG.exception(_LE('There was an error.'))
  raise LocalExceptionClass(_('An error occured.'))

  And oslo.log has the problem,we shuld correct it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ceilometer/+bug/1600788/+subscriptions