← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1604116] [NEW] overcommit ratios should not be able to set to negative value

 

Public bug reported:

Currently the three overcommit ratios: ram_allocation_ratio,
cpu_allocation_ratio, and disk_allocation_ratio can be set to negative
values.

Nova scheduler filters (e.g. CoreFilter) will use these ratios to
calculate free_vcpus/free_ram_mb/usable_disk_mb (which is negative) and
therefore scheduler filters will eventually filter out node which has
negative overcommit ratio.

It makes more sense that these 3 ratios values should not be able to set
to negative values.  If any of these ratios is negative then nova-
compute service should fail to start.

Step to reproduce on devstack:

* On compute node, modify /etc/nova/nova.conf to have "cpu_allocation_ratio = -1.0"
* Restart nova-compute (n-cpu) and nova-compute service is up and running (we should expect nova-compute to fail to start)

** Affects: nova
     Importance: Undecided
     Assignee: vu tran (vu-tran)
         Status: New

** Changed in: nova
     Assignee: (unassigned) => vu tran (vu-tran)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1604116

Title:
  overcommit ratios should not be able to set to negative value

Status in OpenStack Compute (nova):
  New

Bug description:
  Currently the three overcommit ratios: ram_allocation_ratio,
  cpu_allocation_ratio, and disk_allocation_ratio can be set to negative
  values.

  Nova scheduler filters (e.g. CoreFilter) will use these ratios to
  calculate free_vcpus/free_ram_mb/usable_disk_mb (which is negative)
  and therefore scheduler filters will eventually filter out node which
  has negative overcommit ratio.

  It makes more sense that these 3 ratios values should not be able to
  set to negative values.  If any of these ratios is negative then nova-
  compute service should fail to start.

  Step to reproduce on devstack:

  * On compute node, modify /etc/nova/nova.conf to have "cpu_allocation_ratio = -1.0"
  * Restart nova-compute (n-cpu) and nova-compute service is up and running (we should expect nova-compute to fail to start)

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1604116/+subscriptions


Follow ups