yahoo-eng-team team mailing list archive

[OpenStack Infra <1596829@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/342924
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=598dee274c975f3544e09c9bfe4f676ff4643a49
Submitter: Jenkins
Branch:    master

commit 598dee274c975f3544e09c9bfe4f676ff4643a49
Author: Bharath kumar <shettybharath4@xxxxxxxxx>
Date:   Fri Jul 15 15:20:19 2016 +0000

    Following the hacking rule for string interpolation at logging
    
    String interpolation should be delayed to be handled
    by the logging code, rather than being done
    at the point of the logging call.
    
    See the oslo i18n guideline.
    
    * http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages
    
    * http://docs.openstack.org/developer/oslo.i18n/guidelines.html#avoid-forcing-the-translation-of-translatable-variables
    
    
    Change-Id: I96eaede777ca60c7ba2b83ea6968108910b62953
    Closes-Bug: #1596829


** Changed in: ironic
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1596829

Title:
  String interpolation should be delayed at logging calls

Status in Ceilometer:
  New
Status in Glance:
  In Progress
Status in glance_store:
  New
Status in heat:
  New
Status in Ironic:
  Fix Released
Status in OpenStack Identity (keystone):
  New
Status in networking-vsphere:
  Fix Released
Status in neutron:
  Fix Released
Status in OpenStack Compute (nova):
  In Progress
Status in os-brick:
  Fix Released
Status in python-cinderclient:
  Fix Released
Status in python-glanceclient:
  In Progress
Status in OpenStack Object Storage (swift):
  New
Status in taskflow:
  New

Bug description:
  String interpolation should be delayed to be handled by the logging
  code, rather than being done at the point of the logging call.

  Wrong: LOG.debug('Example: %s' % 'bad')
  Right: LOG.debug('Example: %s', 'good')

  See the following guideline.

  * http://docs.openstack.org/developer/oslo.i18n/guidelines.html
  #adding-variables-to-log-messages

  The rule for it should be added to hacking checks.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ceilometer/+bug/1596829/+subscriptions