← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1604196] Re: UX: Misaligned Eye Icon in Create User modal form

 

Reviewed:  https://review.openstack.org/343833
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ccdb7b4ffd08b00fe9dc484a93501511699cc4cd
Submitter: Jenkins
Branch:    master

commit ccdb7b4ffd08b00fe9dc484a93501511699cc4cd
Author: Eddie Ramirez <eddie.ramirez@xxxxxxxxx>
Date:   Mon Jul 18 17:46:54 2016 +0000

    Fix show/hide password when clicking password icon
    
    This patch overrides a Bootstrap's default property that disables
    mouse events on elements with .form-control-feedback class. The password
    icon had pointer-events: none; affecting password reveal functionality
    in login form and Identity->Users->Create User. It also modifies the default
    cursor for the password icon with pointer.
    
    This patch also fixes a bug where the Eye Icon is misaligned when passwords
    don't match (See #1604196)
    
    Change-Id: I052321a5cc9adc1a7ffdfce4da0b55c245481a2d
    Closes-bug: #1593430
    Closes-bug: #1604196


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1604196

Title:
  UX: Misaligned Eye Icon in Create User modal form

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  How to reproduce:
  1. Go to Identity->Users->Create User
  2. A new modal form opens, put different values in "Password" and "Confirm Password".
  3. See how an error message is displayed below the "Confirm Password" text input and the Eye Icon is misaligned because of the msg.

  Expected result:
  Keep Eye icon in place, don't move.

  Actual result:
  The Eye Icon is moved some pixels to the top.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1604196/+subscriptions


References