yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #54094
[Bug 1562250] Re: Enforce PEP8 coding convention - D400:First line should end with a period.
This was fixed by
https://github.com/openstack/keystone/commit/2c4f948db025fb276dfe32eb428a0a68ed879f57
** Changed in: keystone
Assignee: Steve Martinelli (stevemar) => Navid Pustchi (npustchi)
** Changed in: keystone
Milestone: None => newton-1
** Changed in: keystone
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1562250
Title:
Enforce PEP8 coding convention - D400:First line should end with a
period.
Status in OpenStack Identity (keystone):
Fix Released
Bug description:
Current Keystone code base ignores some of the PEP8 coding
conventions. The ignored conventions for the keystone project are
listed here
https://github.com/openstack/keystone/blob/master/tox.ini#L118
Some of the coding conventions that have been put in the ignored list,
are indeed not violated. For example, in current codebase the
following two coding conventions are not violated at all.
# D203: 1 blank required before class docstring.
# D205: Blank line required between one-line summary and description.
On the other hand, some violated conventions are relatively easy to
fix . For example,
#D400: First line should end with a period.
List of all files violating D400 are given here :
https://gist.github.com/Prosunjit/1449708c550364b56ca0
Most of the files that violate D400 are test script (in the
keystone/tests directory), which can be ignored, I guess.
So, this is easy to fix and should be fixed.
To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1562250/+subscriptions
References