← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1286099] Re: UpdateProjectQuotas doesn't pay attention on disabled_quotas

 

Reviewed:  https://review.openstack.org/215277
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=baca29144b5f3e771e780d86210c11e85d8351ed
Submitter: Jenkins
Branch:    master

commit baca29144b5f3e771e780d86210c11e85d8351ed
Author: Timur Sufiev <tsufiev@xxxxxxxxxxxx>
Date:   Fri Aug 21 13:22:03 2015 +0300

    Pay attention to Nova disabled quotas defined in a config file
    
    Since Nova doesn't currently provide an API call to indicate whether
    its quotas are disabled, we could use a parameter named
    'enable_quotas' within 'OPENSTACK_HYPERVISOR_FEATURES' setting for
    this purpose. This allows to avoid errors while trying to update
    quotas which are disabled on service side. Also make disabled_quotas
    collection to be a set instead of a list - this removes duplicate
    fields that appear due to some possible quota overlaps between Nova
    and Neutron.
    
    Also, since we dropped out python2.6 support fancy set literals and
    dict comprehensions can be used.
    
    Co-Authored-By: Paul Karikh <pkarikh@xxxxxxxxxxxx>
    Closes-Bug: #1286099
    Change-Id: I10923f147e4c323aba8bbcc130d2016ad6725e86


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1286099

Title:
  UpdateProjectQuotas doesn't pay attention on disabled_quotas

Status in OpenStack Dashboard (Horizon):
  Fix Released
Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  Environment:
  - OpenStack Havana release (2013.2.1)
  - Neutron

  Steps to reproduce:
  - Go to admin -> projects
  - Try to update project quotas
  - Update fails with "Error: Modified project information and members, but unable to modify project quotas."

  Workaround:
  Comment out "security_group", "security_group_rule" in NEUTRON_QUOTA_FIELDS (openstack_dashboard/usage/quotas.py)

  In neutron/server.log:

  2014-02-28 11:45:03.145 34093 ERROR neutron.api.v2.resource [-] update failed
  2014-02-28 11:45:03.145 34093 TRACE neutron.api.v2.resource Traceback (most recent call last):
  2014-02-28 11:45:03.145 34093 TRACE neutron.api.v2.resource   File "/usr/lib/python2.6/site-packages/neutron/api/v2/resource.py", line 84, in resource
  2014-02-28 11:45:03.145 34093 TRACE neutron.api.v2.resource     result = method(request=request, **args)
  2014-02-28 11:45:03.145 34093 TRACE neutron.api.v2.resource   File "/usr/lib/python2.6/site-packages/neutron/extensions/quotasv2.py", line 107, in update
  2014-02-28 11:45:03.145 34093 TRACE neutron.api.v2.resource     EXTENDED_ATTRIBUTES_2_0[RESOURCE_COLLECTION])
  2014-02-28 11:45:03.145 34093 TRACE neutron.api.v2.resource   File "/usr/lib/python2.6/site-packages/neutron/api/v2/base.py", line 555, in prepare_request_body
  2014-02-28 11:45:03.145 34093 TRACE neutron.api.v2.resource     Controller._verify_attributes(res_dict, attr_info)
  2014-02-28 11:45:03.145 34093 TRACE neutron.api.v2.resource   File "/usr/lib/python2.6/site-packages/neutron/api/v2/base.py", line 602, in _verify_attributes
  2014-02-28 11:45:03.145 34093 TRACE neutron.api.v2.resource     raise webob.exc.HTTPBadRequest(msg)
  2014-02-28 11:45:03.145 34093 TRACE neutron.api.v2.resource HTTPBadRequest: Unrecognized attribute(s) 'security_group_rule, security_group'
  2014-02-28 11:45:03.145 34093 TRACE neutron.api.v2.resource

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1286099/+subscriptions


References