← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1604714] Re: search data once when magic-search has inited

 

Reviewed:  https://review.openstack.org/344692
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=fb4b08ffc7277bfef7b513f6576bbb689c14e8c4
Submitter: Jenkins
Branch:    master

commit fb4b08ffc7277bfef7b513f6576bbb689c14e8c4
Author: majik <xu.jun@xxxxxxxxxxx>
Date:   Wed Jul 20 17:55:16 2016 +0800

    fix magic search bug
    
    Two same requests are sent when magic-search is on load.
    One is right, but another is called by the search event.
    The second one should not happen.
    
    The initial data of currentServerSearchParams in stMagicSearch is wrong,
    which should be {magicSearchQuery: ""} instead of {}.
    
    Change-Id: Ia1e28e848daabe5685cb7a01c80ca1296131e616
    Closes-Bug: #1604714


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1604714

Title:
  search data once when magic-search has inited

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  When the page which containers hz-resource-table(magic-search) is on
  load, it sends get the same data twice. One is right, but another is
  called by the search event. The second one should not happen.

  I find it out that the initial data of currentServerSearchParams in stMagicSearch is incorrect.
  Initial currentServerSearchParams is {}, however, which should be {magicSearchQuery: ""}.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1604714/+subscriptions


References