← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1605894] Re: some test_l3 unit test failures

 

Reviewed:  https://review.openstack.org/346585
Committed: https://git.openstack.org/cgit/openstack/networking-midonet/commit/?id=0fa57a25a683bb1c85a839dba4bb253aa9551ad0
Submitter: Jenkins
Branch:    master

commit 0fa57a25a683bb1c85a839dba4bb253aa9551ad0
Author: YAMAMOTO Takashi <yamamoto@xxxxxxxxxxxx>
Date:   Mon Jul 25 13:37:29 2016 +0900

    l3: Avoid breaking transaction in _validate_router_port_info
    
    The recent Neutron change [1] broke plugins which have a surrounding
    transaction for the method.  This commit workarounds the breakage by
    avoid breaking the whole transaction in _validate_router_port_info.
    
    [1] I797df266dafc41843408dc95a6ce9f986db5c21c
    
    Closes-Bug: #1605894
    Change-Id: Ib2fff32642013af2523b159a48c7e2bc8c854131


** Changed in: networking-midonet
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1605894

Title:
  some test_l3 unit test failures

Status in networking-midonet:
  Fix Released
Status in neutron:
  In Progress

Bug description:
  networking-midonet gate fails due to recent l3_db change. [1]
  any plugins which have a surrounding transaction for add_router_interface
  would be affected in the same way.

  [1] I797df266dafc41843408dc95a6ce9f986db5c21c

  http://logs.openstack.org/00/344100/2/check/gate-networking-midonet-
  python27/f55680d/console.html

  2016-07-23 10:56:05.220890 | ======================================================================
  2016-07-23 10:56:05.220921 | FAIL: midonet.neutron.tests.unit.test_midonet_plugin.TestMidonetL3NatDBIntTest.test_router_add_interface_dup_subnet2_returns_400
  2016-07-23 10:56:05.220941 | ----------------------------------------------------------------------
  2016-07-23 10:56:05.220953 | Traceback (most recent call last):
  2016-07-23 10:56:05.220984 |   File "/tmp/openstack/neutron/neutron/tests/unit/extensions/test_l3.py", line 1425, in test_router_add_interface_dup_subnet2_returns_400
  2016-07-23 10:56:05.221003 |     expected_code=exc.HTTPBadRequest.code)
  2016-07-23 10:56:05.221029 |   File "/tmp/openstack/neutron/neutron/tests/unit/extensions/test_l3.py", line 403, in _router_interface_action
  2016-07-23 10:56:05.221046 |     self.assertEqual(expected_code, res.status_int, msg)
  2016-07-23 10:56:05.221081 |   File "/home/jenkins/workspace/gate-networking-midonet-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 411, in assertEqual
  2016-07-23 10:56:05.221101 |     self.assertThat(observed, matcher, message)
  2016-07-23 10:56:05.221136 |   File "/home/jenkins/workspace/gate-networking-midonet-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 498, in assertThat
  2016-07-23 10:56:05.221146 |     raise mismatch_error
  2016-07-23 10:56:05.221160 | testtools.matchers._impl.MismatchError: 400 != 500
  2016-07-23 10:56:05.221178 | ======================================================================
  2016-07-23 10:56:05.221211 | FAIL: midonet.neutron.tests.unit.test_midonet_plugin.TestMidonetL3NatDBIntTest.test_router_add_interface_ipv6_port_existing_network_returns_400
  2016-07-23 10:56:05.221235 | ----------------------------------------------------------------------
  2016-07-23 10:56:05.221247 | Traceback (most recent call last):
  2016-07-23 10:56:05.221281 |   File "/tmp/openstack/neutron/neutron/tests/unit/extensions/test_l3.py", line 1316, in test_router_add_interface_ipv6_port_existing_network_returns_400
  2016-07-23 10:56:05.221297 |     expected_code=exp_code)
  2016-07-23 10:56:05.221324 |   File "/tmp/openstack/neutron/neutron/tests/unit/extensions/test_l3.py", line 403, in _router_interface_action
  2016-07-23 10:56:05.221349 |     self.assertEqual(expected_code, res.status_int, msg)
  2016-07-23 10:56:05.221386 |   File "/home/jenkins/workspace/gate-networking-midonet-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 411, in assertEqual
  2016-07-23 10:56:05.221400 |     self.assertThat(observed, matcher, message)
  2016-07-23 10:56:05.221435 |   File "/home/jenkins/workspace/gate-networking-midonet-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 498, in assertThat
  2016-07-23 10:56:05.221445 |     raise mismatch_error
  2016-07-23 10:56:05.221459 | testtools.matchers._impl.MismatchError: 400 != 500
  2016-07-23 10:56:05.221477 | ======================================================================
  2016-07-23 10:56:05.221509 | FAIL: midonet.neutron.tests.unit.test_midonet_plugin.TestMidonetL3NatDBIntTest.test_router_add_interface_multiple_ipv4_subnet_port_returns_400
  2016-07-23 10:56:05.221528 | ----------------------------------------------------------------------
  2016-07-23 10:56:05.221540 | Traceback (most recent call last):
  2016-07-23 10:56:05.221574 |   File "/tmp/openstack/neutron/neutron/tests/unit/extensions/test_l3.py", line 1287, in test_router_add_interface_multiple_ipv4_subnet_port_returns_400
  2016-07-23 10:56:05.221584 |     expected_code=exp_code)
  2016-07-23 10:56:05.221610 |   File "/tmp/openstack/neutron/neutron/tests/unit/extensions/test_l3.py", line 403, in _router_interface_action
  2016-07-23 10:56:05.221626 |     self.assertEqual(expected_code, res.status_int, msg)
  2016-07-23 10:56:05.221660 |   File "/home/jenkins/workspace/gate-networking-midonet-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 411, in assertEqual
  2016-07-23 10:56:05.221675 |     self.assertThat(observed, matcher, message)
  2016-07-23 10:56:05.221709 |   File "/home/jenkins/workspace/gate-networking-midonet-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 498, in assertThat
  2016-07-23 10:56:05.221719 |     raise mismatch_error
  2016-07-23 10:56:05.221734 | testtools.matchers._impl.MismatchError: 400 != 500
  2016-07-23 10:56:05.221752 | ======================================================================
  2016-07-23 10:56:05.221782 | FAIL: midonet.neutron.tests.unit.test_midonet_plugin_v2.TestMidonetL3NatExtraRoute.test_router_add_interface_dup_subnet2_returns_400
  2016-07-23 10:56:05.221801 | ----------------------------------------------------------------------
  2016-07-23 10:56:05.221812 | Traceback (most recent call last):
  2016-07-23 10:56:05.221843 |   File "/tmp/openstack/neutron/neutron/tests/unit/extensions/test_l3.py", line 1425, in test_router_add_interface_dup_subnet2_returns_400
  2016-07-23 10:56:05.221856 |     expected_code=exc.HTTPBadRequest.code)
  2016-07-23 10:56:05.221882 |   File "/tmp/openstack/neutron/neutron/tests/unit/extensions/test_l3.py", line 403, in _router_interface_action
  2016-07-23 10:56:05.221898 |     self.assertEqual(expected_code, res.status_int, msg)
  2016-07-23 10:56:05.222052 |   File "/home/jenkins/workspace/gate-networking-midonet-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 411, in assertEqual
  2016-07-23 10:56:05.222076 |     self.assertThat(observed, matcher, message)
  2016-07-23 10:56:05.222111 |   File "/home/jenkins/workspace/gate-networking-midonet-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 498, in assertThat
  2016-07-23 10:56:05.222121 |     raise mismatch_error
  2016-07-23 10:56:05.222135 | testtools.matchers._impl.MismatchError: 400 != 500
  2016-07-23 10:56:05.222154 | ======================================================================
  2016-07-23 10:56:05.222186 | FAIL: midonet.neutron.tests.unit.test_midonet_plugin_v2.TestMidonetL3NatExtraRoute.test_router_add_interface_ipv6_port_existing_network_returns_400
  2016-07-23 10:56:05.222205 | ----------------------------------------------------------------------
  2016-07-23 10:56:05.222217 | Traceback (most recent call last):
  2016-07-23 10:56:05.222259 |   File "/tmp/openstack/neutron/neutron/tests/unit/extensions/test_l3.py", line 1316, in test_router_add_interface_ipv6_port_existing_network_returns_400
  2016-07-23 10:56:05.222272 |     expected_code=exp_code)
  2016-07-23 10:56:05.222298 |   File "/tmp/openstack/neutron/neutron/tests/unit/extensions/test_l3.py", line 403, in _router_interface_action
  2016-07-23 10:56:05.222314 |     self.assertEqual(expected_code, res.status_int, msg)
  2016-07-23 10:56:05.222348 |   File "/home/jenkins/workspace/gate-networking-midonet-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 411, in assertEqual
  2016-07-23 10:56:05.222363 |     self.assertThat(observed, matcher, message)
  2016-07-23 10:56:05.222397 |   File "/home/jenkins/workspace/gate-networking-midonet-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 498, in assertThat
  2016-07-23 10:56:05.222407 |     raise mismatch_error
  2016-07-23 10:56:05.222422 | testtools.matchers._impl.MismatchError: 400 != 500
  2016-07-23 10:56:05.222440 | ======================================================================
  2016-07-23 10:56:05.222473 | FAIL: midonet.neutron.tests.unit.test_midonet_plugin_v2.TestMidonetL3NatExtraRoute.test_router_add_interface_multiple_ipv4_subnet_port_returns_400
  2016-07-23 10:56:05.222491 | ----------------------------------------------------------------------
  2016-07-23 10:56:05.222503 | Traceback (most recent call last):
  2016-07-23 10:56:05.222536 |   File "/tmp/openstack/neutron/neutron/tests/unit/extensions/test_l3.py", line 1287, in test_router_add_interface_multiple_ipv4_subnet_port_returns_400
  2016-07-23 10:56:05.222547 |     expected_code=exp_code)
  2016-07-23 10:56:05.222573 |   File "/tmp/openstack/neutron/neutron/tests/unit/extensions/test_l3.py", line 403, in _router_interface_action
  2016-07-23 10:56:05.222589 |     self.assertEqual(expected_code, res.status_int, msg)
  2016-07-23 10:56:05.222623 |   File "/home/jenkins/workspace/gate-networking-midonet-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 411, in assertEqual
  2016-07-23 10:56:05.222637 |     self.assertThat(observed, matcher, message)
  2016-07-23 10:56:05.222672 |   File "/home/jenkins/workspace/gate-networking-midonet-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 498, in assertThat
  2016-07-23 10:56:05.222682 |     raise mismatch_error
  2016-07-23 10:56:05.222696 | testtools.matchers._impl.MismatchError: 400 != 500

To manage notifications about this bug go to:
https://bugs.launchpad.net/networking-midonet/+bug/1605894/+subscriptions